Bug 970929

Summary: Review Request: php-nrk-Predis - PHP client library for Redis
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, shawn
Target Milestone: ---Flags: shawn: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: php-nrk-Predis-0.8.3-2.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-16 01:24:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 970927    
Bug Blocks: 970930    
Attachments:
Description Flags
phpci
none
fedora-review none

Description Remi Collet 2013-06-05 08:59:08 UTC
Spec URL: https://raw.github.com/remicollet/remirepo/391bea69f62cda0ef358dbf8de8f94fac49855d9/php/php-nrk-Predis/php-nrk-Predis.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-nrk-Predis-0.8.3-1.remi.src.rpm
Description: 
Flexible and feature-complete PHP client library for Redis.

Fedora Account System Username: remi

Comment 1 Shawn Iwinski 2013-06-30 17:46:15 UTC
Build error:

+ /usr/bin/pear install --nodeps --packagingroot /builddir/build/BUILDROOT/php-nrk-Predis-0.8.3-1.fc20.x86_64 php-nrk-Predis.xml
parsePackageName(): only one version/state delimiter "-" is allowed in "php-nrk-Predis.xml"
Parsing of package.xml from file "php-nrk-Predis.xml" failed

Comment 2 Remi Collet 2013-06-30 18:04:36 UTC
I will check as soon as php-channel-nrk will be available in rawhide.
Very strange as local and mock build succeed locally for me.

Comment 3 Remi Collet 2013-07-01 15:53:53 UTC
Shawn, can you check if channel nrk is properly registered on your system (pear list-channels). I suspect a bad channel.xml in your build environment.

Koji scratch build Rawide (test enabled):
http://koji.fedoraproject.org/koji/taskinfo?taskID=5562340

Koji scratch build EPEL-6 (test disabled because of old redis version):
http://koji.fedoraproject.org/koji/taskinfo?taskID=5562342


Notice : php-channel-brk is now in updates-testing and in buildroot (override) for F18, F19 and EPEL-6

Comment 4 Shawn Iwinski 2013-07-02 19:49:57 UTC
Created attachment 767926 [details]
phpci

phpcompatinfo version 2.17.0

NOTE: False positive for min PHP version 5.4.0

Comment 5 Shawn Iwinski 2013-07-02 19:50:52 UTC
Created attachment 767927 [details]
fedora-review

Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 970929

Comment 6 Shawn Iwinski 2013-07-02 19:55:55 UTC
(In reply to Remi Collet from comment #3)
> Shawn, can you check if channel nrk is properly registered on your system
> (pear list-channels). I suspect a bad channel.xml in your build environment.

My mock env needed to be removed and then recreated which fixed my issue.  Sorry.



Issues:
=======
- Sources used to build the package match the upstream source, as provided in
  the spec URL.
  Note: Upstream MD5sum check error, diff is in
  /home/siwinski/projects/fedora/reviews/970929-php-nrk-Predis/diff.txt
  See: http://fedoraproject.org/wiki/Packaging/SourceURL

http://pear.nrk.io/get/Predis-0.8.3.tgz :
  CHECKSUM(SHA256) this package     : 21f69d36a18faa2eca86c0e37798668f2b1fe1a32a3688e869a93206617cc198
  CHECKSUM(SHA256) upstream package : ce9f28ce5ae4a866f085464f0b87e552a919e7947559dae659bd6bd1ecd5fcdc

Your SRPM does not contain the updated tarball after https://github.com/nrk/predis/issues/125 was fixed.  Please fix the SRPM (no release bump needed) and I will approve this package.



NICE work with upstream by the way!!!

Comment 8 Shawn Iwinski 2013-07-03 05:41:43 UTC
Source fixed

===== APPROVED =====

Comment 9 Remi Collet 2013-07-03 05:46:26 UTC
Thanks for this review

New Package SCM Request
=======================
Package Name: php-nrk-Predis
Short Description: PHP client library for Redis
Owners: remi
Branches: f18 f19 el6
InitialCC:

Comment 10 Gwyn Ciesla 2013-07-03 12:55:02 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2013-07-04 07:05:19 UTC
php-nrk-Predis-0.8.3-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-nrk-Predis-0.8.3-2.fc18

Comment 12 Fedora Update System 2013-07-04 07:05:29 UTC
php-nrk-Predis-0.8.3-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-nrk-Predis-0.8.3-2.el6

Comment 13 Fedora Update System 2013-07-04 07:05:38 UTC
php-nrk-Predis-0.8.3-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/php-nrk-Predis-0.8.3-2.fc19

Comment 14 Fedora Update System 2013-07-04 20:00:13 UTC
Package php-nrk-Predis-0.8.3-2.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing php-nrk-Predis-0.8.3-2.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-10734/php-nrk-Predis-0.8.3-2.el6
then log in and leave karma (feedback).

Comment 15 Fedora Update System 2013-07-16 01:24:37 UTC
php-nrk-Predis-0.8.3-2.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2013-07-16 01:31:18 UTC
php-nrk-Predis-0.8.3-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2013-07-21 18:39:39 UTC
php-nrk-Predis-0.8.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.