Bug 970951
| Summary: | Should not print "control action not implemented" when git push for php application | ||
|---|---|---|---|
| Product: | OpenShift Online | Reporter: | Wei Sun <wsun> |
| Component: | Containers | Assignee: | Dan Mace <dmace> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | libra bugs <libra-bugs> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | 2.x | CC: | dmace, jhonce, jhou, vvitek, wsun, xtian |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-07-22 15:15:56 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Wei Sun
2013-06-05 09:59:11 UTC
@wsun @jhonce
Would you be OK with
> remote: CLIENT_MESSAGE: `pre-repo-archive' nothing to do
messages?
Or do you want me to clear the output (print nothing) in such cases?
If you do not implement the action you should just return 0, no message or logging should be done. Already patched in master and prod, but will require a v2=>v2 migration for existing apps: https://github.com/openshift/origin-server/pull/2773 https://github.com/openshift/origin-server/pull/2789 Check this bug on INT(devenv_3373),seems it was fixed.We will verify this bug after it is ON_QA. Result: [sunwei@dhcp-8-229 phpt]$ gitpush [master 12647fe] test Counting objects: 5, done. Delta compression using up to 4 threads. Compressing objects: 100% (3/3), done. Writing objects: 100% (3/3), 275 bytes, done. Total 3 (delta 2), reused 0 (delta 0) remote: CLIENT_MESSAGE: Stopping Apache+mod_php HTTPD server remote: Waiting for stop to finish remote: CLIENT_MESSAGE: Starting Apache+mod_php HTTPD server To ssh://51c079916cec0e2353000ab2.rhcloud.com/~/git/phpt.git/ 24e6382..12647fe master -> master We're still waiting on v2->v2 migration to finish. V2 migration has been executed on INT, and the git push output is cleaner now. Total 5 (delta 4), reused 0 (delta 0) remote: CLIENT_MESSAGE: Stopping Apache+mod_php HTTPD server remote: Waiting for stop to finish remote: [Thu Jun 20 02:55:52 2013] [warn] module php5_module is already loaded, skipping remote: Waiting for stop to finish remote: [Thu Jun 20 02:56:22 2013] [warn] module php5_module is already loaded, skipping remote: remote: Database schema not yet added, WordPress is ready for install by visiting the site. remote: CLIENT_MESSAGE: Starting Apache+mod_php HTTPD server To ssh://51be83d16cec0e07f0000bf6.rhcloud.com/~/git/wordpress.git/ cc8e9e2..4e9ec73 master -> master (In reply to Vojtech Vitek from comment #5) Hi, Vojtech Are there any more changes coming for this bug? if not, please help to move it to ON_QA. Thanks I already patched this; moving to ON_QA. Thanks! |