Bug 971120
| Summary: | oo-accept-node should detect gears without cartridge directories | ||
|---|---|---|---|
| Product: | OpenShift Online | Reporter: | Paul Morie <pmorie> |
| Component: | Containers | Assignee: | Paul Morie <pmorie> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | libra bugs <libra-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 2.x | CC: | bmeng, chunchen, dmcphers, pmorie, xtian |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-07 22:54:25 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Paul Morie
2013-06-05 18:13:50 UTC
PR submitted to master. PR failed because of accept-node failures. I've found also that devenv test does not create the cucumber log. Another change that should happen for this bug is that the cartridge migration should fail if a gear has no cartridges. Since there's more change coming for this bug, move it back to ASSIGNED in case it's missed from the filter list Commit pushed to master at https://github.com/openshift/li https://github.com/openshift/li/commit/028b0ec151c77e5dfcf525282798d407cf6e980d Bug 971120: remove node.feature and online_node_steps.rb Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/6cfb9c204a4d8bfb8a0edfede9bc9b34fbd4cc3d Bug 971120: refactor openshift-node.feature Hi Paul, Any code change for this bug? Seems the two PRs only for the unit test. And checked on devenv-stage_429. The issue still can be reproduced. Bo Meng- Hahaha. I had a lot of trouble with the cucumber tests and actually started over trying to get the changes to the cuke tests to work. I must have forgotten to actually make the change in oo-accept-node. Thanks, P Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/c996164f7df12880e774011bcd442cf3362dc809 Fix bug 971120: add empty gear check for oo-accept-node Commit pushed to master at https://github.com/openshift/li https://github.com/openshift/li/commit/9d59520165e119a6a55b8b9d4b2a64305e875a57 Bug 971120: remove node.feature and online_node_steps.rb Checked on devenv_3604, issue fixed. # oo-accept-node -v INFO: loading node configuration file /etc/openshift/node.conf INFO: loading resource limit file /etc/openshift/resource_limits.conf INFO: finding external network device INFO: checking node public hostname resolution INFO: checking selinux status INFO: checking selinux openshift-hosted policy INFO: checking selinux booleans INFO: checking selinux nodes INFO: checking package list INFO: checking services INFO: checking kernel semaphores >= 512 INFO: checking cgroups configuration INFO: checking cgroups processes INFO: checking presence of tc qdisc INFO: checking for cgroup filter INFO: checking presence of tc classes INFO: checking filesystem quotas INFO: checking quota db file selinux label INFO: checking 2 user accounts INFO: checking application dirs FAIL: directory 604176745706929942167552 doesn't have a cartridge directory INFO: checking system httpd configs INFO: checking cartridge repository 1 ERRORS |