Bug 971236
| Summary: | Review Request: sugar-deducto - A learning activity aimed towards improving children's skills to deducing logic | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Danishka Navin <danishka> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | sugar-deducto-9-5.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-15 02:44:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Danishka Navin
2013-06-06 05:51:33 UTC
Review:-
+ Package builds in mock successfully
+ rpmlint on rpms gave
sugar-deducto.noarch: W: spelling-error %description -l en_US children's -> children, childcare's, Nichiren's
sugar-deducto.src: W: spelling-error %description -l en_US children's -> children, childcare's, Nichiren's
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
==> this can be ignored
+ Source verified with upstream as (sha256sum)
srpm tarball : db7bdea1c281aa9f6a850f58edb01388efe24568336bfa733472b17c385ed53a
upstream tarball : db7bdea1c281aa9f6a850f58edb01388efe24568336bfa733472b17c385ed53a
- License tag is not completely valid.
+ Rest looks as per packaging guidelines.
Suggestions:
1) Don't use any backslash between %{buildroot} and %{_prefix}, so your %install should look like
%{__python} ./setup.py install --prefix=%{buildroot}%{_prefix}
2) License tag should be GPLv3+ and MIT.
Read https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses
Also, Add a comment above license tag
# sprites.py is in MIT and all other files in GPLv3+
corrected the spec and rebuild as per instructions in the comment #1 SPEC URL: http://snavin.fedorapeople.org/packages/sugar-deducto/sugar-deducto.spec SRPM URL: http://snavin.fedorapeople.org/packages/sugar-deducto/sugar-deducto-9-2.fc18.src.rpm You missed to update license tag. Read Suggestion 2 again. You need to set it GPLv3+ and MIT. correct license tag SPEC URL: http://snavin.fedorapeople.org/packages/sugar-deducto/sugar-deducto.spec SRPM URL: http://snavin.fedorapeople.org/packages/sugar-deducto/sugar-deducto-9-3.fc18.src.rpm I see spelling mistake in latest changelog. Please change tab to tag. Otherwise recent srpm Looks good now. APPROVED. Do i need to correct it and add new changelog for that? or just correct the changelog and send with the same version by replacing old package? no changelog needed but correct it before you build officially on koji. correct the typo in changelog SPEC URL: http://snavin.fedorapeople.org/packages/sugar-deducto/sugar-deducto.spec SRPM URL: http://snavin.fedorapeople.org/packages/sugar-deducto/sugar-deducto-9-3.fc18.src.rpm New Package SCM Request ======================= Package Name: sugar-deducto Short Description: A learning activity aimed towards improving children's skills to deducing logic Owners: snavin Branches: f17 f18 f19 InitialCC: Git done (by process-git-requests). sugar-deducto-9-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/sugar-deducto-9-5.fc18 sugar-deducto-9-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/sugar-deducto-9-5.fc19 sugar-deducto-9-5.fc19 has been pushed to the Fedora 19 testing repository. sugar-deducto-9-5.fc18 has been pushed to the Fedora 18 stable repository. sugar-deducto-9-5.fc19 has been pushed to the Fedora 19 stable repository. |