Bug 971558
Summary: | spice via gi just prints warning if http proxy fails, would prefer the error be raised to the client | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Marcelo Ricardo Leitner <mleitner> |
Component: | virt-manager | Assignee: | Cole Robinson <crobinso> |
Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | high | Docs Contact: | |
Priority: | unspecified | ||
Version: | 19 | CC: | berrange, cfergeau, crobinso, hbrock, hdegoede, jforbes, marcandre.lureau, mleitner, sandmann, virt-maint |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-09-01 17:26:52 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Marcelo Ricardo Leitner
2013-06-06 19:54:57 UTC
Well.. not so sure about guest name anymore: Installed another guest, named Fedora2, and same issue: can't open console via virt-manager when http_proxy environment var is configured, even though no proxy request is done. Fedora2 is not a dns resolvable in here, just in case. Guest name that works: sf00000000 (where 0 are actual numbers) Please provide virt-manager --debug when reproducing, something weird must be going on. Also 'sudo virsh dumpxml $vmname' of the working VM and the non working VMs Shame on me for not noticing this difference before. --debug allowed me to spot it: My guests that work, are using VNC. My guests that aren't working, are using Spice, and spice requests are issued through proxy, while vnc ones aren't: 2013-06-13 15:20:51,865 (console:1138): Starting connect process for proto=spice trans=None connhost=localhost connuser=None connport=None gaddr=127.0.0.1 gport=5902 gsocket=N one 2013-06-13 15:20:51,866 (console:561): spice uri: spice://127.0.0.1?port=5902 (virt-manager:11263): GSpice-WARNING **: HTTP proxy connection failed: 403 Forbidden 2013-06-13 15:21:07,640 (console:413): VNC connection to 127.0.0.1:5902 2013-06-13 15:21:07,927 (console:1053): Viewer connected And I failed to notice that Forbidden logged in my proxy log, ugh. Allowed Spice through the proxy and it worked. Is it really intended to run Spice through the proxy?? If yes, I think we are done here, thanks. Yeah I think that's expected behavior. If anything VNC not acknowledging proxy settings is the bug. Closing Hey Cole, but shouldn't we display a better error message, in case of spice/proxy thing? Like we do when connect() fail. I mean, relying on --debug or proxy logs (not always available to one who needs it) to catch this is too internal. Thanks, Marcelo. (In reply to Marcelo Ricardo Leitner from comment #5) > Hey Cole, but shouldn't we display a better error message, in case of > spice/proxy thing? Like we do when connect() fail. I mean, relying on > --debug or proxy logs (not always available to one who needs it) to catch > this is too internal. > Agreed it would be nice if we had a way to get this error programmatically in clients, but I don't think spice-gtk gives us a way to do that. Reassigning. Did you set the SPICE_PROXY variable? I wonder why the spice http proxy is involved here. Regarding error handling, spice-gtk does provide some (although it would need to be impreved, yes), and virt-viewer shows a dialog on connection error. It seems to work in this case too, when proxy fails. There is a channel-event signal, and the event in this case is SPICE_CHANNEL_ERROR_CONNECT (In reply to Marc-Andre Lureau from comment #7) > Did you set the SPICE_PROXY variable? I wonder why the spice http proxy is > involved here. Nope: $ export | grep -i proxy declare -x ftp_proxy="http://localhost:3128/" declare -x http_proxy="http://localhost:3128/" $ That was my surprise too, why it was using it. Thanks for the pointer Marc-Andre. virt-manager catches spice connection errors now: commit 82ef6ba1737d1dbe98c70e99bea299e584148ef8 Author: Cole Robinson <crobinso> Date: Sun Sep 1 13:25:37 2013 -0400 console: Catch spice connection errors (bz #971558) Just closing as UPSTREAM, this will hit Fedora when we rebase |