Bug 971821
| Summary: | vzctl-4.3.1-2.fc18 is FTBFS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Horák <dan> | ||||||
| Component: | vzctl | Assignee: | Glauber Costa <glommer> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 18 | CC: | avagin, glommer | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | s390x | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | vzctl-4.3.1-3.fc18 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-06-16 06:08:30 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 467765 | ||||||||
| Attachments: |
|
||||||||
Created attachment 758136 [details]
Fix compilation on architectures without support for VZ
Dan, thank you for the report. Could you try out this patch?
Created attachment 758138 [details]
Fix compilation on architectures without support for VZ
(In reply to Andrey Vagin from comment #2) > Created attachment 758138 [details] > Fix compilation on architectures without support for VZ yes, this patch fixes the build. Maybe there would be a better place for the fallback implementation of clean_hardlink_dir() as there are 2 places where it is used - env.c and cpt.c. clean_hardlink_dir makes sense only for VZ kernel. Actually not all VZ specific functionality is moved out in hooks_vz, when this work will be completed, we will remove this workaround. (In reply to Andrey Vagin from comment #4) > clean_hardlink_dir makes sense only for VZ kernel. Actually not all VZ > specific functionality is moved out in hooks_vz, when this work will be > completed, we will remove this workaround. no objections :-) Are you going to build updates packages with this workaround included or should I take care of it? vzctl-4.3.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/vzctl-4.3.1-3.fc18 vzctl-4.3.1-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/vzctl-4.3.1-3.fc19 Package vzctl-4.3.1-3.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing vzctl-4.3.1-3.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-10371/vzctl-4.3.1-3.fc19 then log in and leave karma (feedback). vzctl-4.3.1-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. vzctl-4.3.1-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |
current vzctl fails to build on s390x with ... CCLD arpsend CCLD ndsend CCLD vzcalc CCLD vzcfgvalidate CCLD vzcptcheck lib/.libs/libvzctl.so: undefined reference to `clean_hardlink_dir' collect2: error: ld returned 1 exit status make[2]: *** [vzcalc] Error 1 make[2]: *** Waiting for unfinished jobs.... lib/.libs/libvzctl.so: undefined reference to `clean_hardlink_dir' collect2: error: ld returned 1 exit status make[2]: *** [vzcfgvalidate] Error 1 ... The clean_hardlink_dir() function is defined in lib/hooks_vz.c, but this file is compiled only when the kernel support for VZ exists ("if HAVE_VZ_KERNEL" is in Makefile.am). Version-Release number of selected component (if applicable): vzctl-4.3.1-2.fc18