Bug 972224
| Summary: | Review Request: extlinux-bootloader - The EXTLINUX bootloader framework, for booting the local system. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dennis Gilmore <dennis> |
| Component: | Package Review | Assignee: | Jon Disnard <jdisnard> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jdisnard, notting, package-review |
| Target Milestone: | --- | Flags: | jdisnard:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-06-22 01:22:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dennis Gilmore
2013-06-07 20:55:41 UTC
Hello Dennis. Please note this is my first review. Build your package in mock using a Samsung Chromebook running f19. The package is very simple and built as expected without any problems at all. The rpmlint utility did not show any errors, and the warnings were BS. $ rpmlint extlinux-bootloader-1.0-1.fc19.src.rpm extlinux-bootloader.src: W: summary-ended-with-dot C The EXTLINUX bootloader framework, for booting the local system. extlinux-bootloader.src: W: spelling-error %description -l en_US conf -> con, cone, cons extlinux-bootloader.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure extlinux-bootloader.src: W: invalid-url URL: http://fedoraproject.org/wiki/extlinux-bootloader HTTP Error 404: Not Found extlinux-bootloader.src:9: W: unversioned-explicit-provides syslinux-extlinux 1 packages and 0 specfiles checked; 0 errors, 5 warnings. As far as I can tell the package works as intended, but I have not performed an Anaconda steps to ensure. So I give this a +1 upon more review I found a problem as reported by rpmlint.
The package does not produce a binary file for armv7hl, just a text file.
However the spec file has 'ExclusiveArch: %{arm}'
Please consider changing to a noarch package since it is a text file, but keep the ExclusiveArch.
$ rpmlint extlinux-bootloader-1.0-1.fc19.armv7hl.rpm
extlinux-bootloader.armv7hl: W: summary-ended-with-dot C The EXTLINUX bootloader framework, for booting the local system.
extlinux-bootloader.armv7hl: W: spelling-error %description -l en_US conf -> con, cone, cons
extlinux-bootloader.armv7hl: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
extlinux-bootloader.armv7hl: W: invalid-url URL: http://fedoraproject.org/wiki/extlinux-bootloader HTTP Error 404: Not Found
extlinux-bootloader.armv7hl: E: no-binary
extlinux-bootloader.armv7hl: W: no-documentation
extlinux-bootloader.armv7hl: W: dangling-relative-symlink /etc/extlinux.conf ../boot/extlinux/extlinux.conf
extlinux-bootloader.armv7hl: W: no-manual-page-for-binary extlinux
1 packages and 0 specfiles checked; 1 errors, 7 warnings.
After some discussion looks like we can ignore the so-called error in rpmlint. New Package SCM Request ======================= Package Name: extlinux-bootloader Short Description: The EXTLINUX bootloader framework, for booting the local system Owners: ausil Branches: f19 InitialCC: Git done (by process-git-requests). built and in |