Bug 972308

Summary:	[upgrade] oo-accept-broker will throw an error due to ownership of user_action.log is changed.
Product:	OpenShift Container Platform	Reporter:	Johnny Liu <jialiu>
Component:	Cluster Version Operator	Assignee:	Jason DeTiberus <jdetiber>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	1.2.0	CC:	bleanhar, jdetiber, libra-onpremise-devel
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openshift-origin-broker-util-1.9.7-1.1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-06-28 15:46:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Johnny Liu 2013-06-08 09:31:59 UTC

Description of problem:
After upgrade, run oo-accept-broker, get the following error:
[root@broker ~]# oo-accept-broker 
FAIL: Rest API Logging enabled but the log file has wrong owner -- run chown apache:apache /var/log/openshift/broker/user_action.log
NOTICE: SELinux is Enforcing
NOTICE: SELinux is  Enforcing
1 ERRORS


Version-Release number of selected component (if applicable):
1.2/2013-06-07.2

How reproducible:
Always

Steps to Reproduce:
1. Setup ose-1.1.3 env, the ownership of /var/log/openshift/broker/user_action.log is apache:apache
2. Create a app, run oo-accept-broker, and passed.
3. Following http://etherpad.corp.redhat.com/OSE-1-2-upgrade-notes to do upgrade testing
4. After upgrade, check the ownership of /var/log/openshift/broker/user_action.log, run oo-accept-broker again. 

Actual results:
oo-accept-broker failed.

[root@broker ~]# oo-accept-broker 
FAIL: Rest API Logging enabled but the log file has wrong owner -- run chown apache:apache /var/log/openshift/broker/user_action.log
NOTICE: SELinux is Enforcing
NOTICE: SELinux is  Enforcing
1 ERRORS

[root@broker ~]# ll /var/log/openshift/broker/user_action.log
-rw-r-----. 1 apache root 5712 Jun  8 02:27 /var/log/openshift/broker/user_action.log


Expected results:
oo-accept-broker should pass.

Additional info:

Comment 2 Jason DeTiberus 2013-06-11 18:23:28 UTC

Origin: https://github.com/openshift/origin-server/pull/2813
Enterprise: https://github.com/openshift/enterprise-server/pull/79

Comment 3 openshift-github-bot 2013-06-11 21:44:25 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/d58378fb0190bf93ba6c001afb06dd9849b12cbf
<broker-util> Bug 972308 - Update permissions check for user_action.log

https://bugzilla.redhat.com/show_bug.cgi?id=972308

The permissions check for the user action log was testing if owner and
group were apache, really we only care that the owner is apache.

Comment 4 Johnny Liu 2013-06-21 11:07:05 UTC

Verified this bug with openshift-origin-broker-util-1.9.7-1.1.el6op.noarch in 1.2/2013-06-20.5 puddle, it PASS.

oo-accept-broker succeed after migration.

Comment 5 Luke Meyer 2013-06-28 15:46:28 UTC

Closing all bugs introduced, fixed, and verified during 1.2 release work (thus never shipped).