Bug 973151

Summary: inconsistent redis's systemd unit
Product: [Fedora] Fedora Reporter: Sebastien Pasche <braoru>
Component: redisAssignee: Silas Sewell <silas>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 18CC: fabian.deutsch, fdeutsch, james.juran, silas
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Unspecified   
Whiteboard:
Fixed In Version: redis-2.6.16-1.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-23 00:50:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sebastien Pasche 2013-06-11 11:35:48 UTC
Description of problem:

No pid file created tu pidfile present into systemd unit.
Redis not started as a daemon but package as it.

Version-Release number of selected component (if applicable):

[root@mgbshipf01 run]# rpm -qa | grep redis
redis-2.4.15-3.fc18.x86_64

How reproducible:

yum install redis
systemctl start redis.service

Steps to Reproduce:
1. Install redis
2. start it
3.

Actual results:

Redis is running but no pid created

Expected results:

Redis running in a daemonized form and create a pid

Additional info:

Remember that redis is forking 1 time and does not check if redis daemon is already running !

void daemonize(void) {
    int fd;

    if (fork() != 0) exit(0); /* parent exits */
    setsid(); /* create a new session */

    /* Every output goes to /dev/null. If Redis is daemonized but
     * the 'logfile' is set to 'stdout' in the configuration file
     * it will not log at all. */
    if ((fd = open("/dev/null", O_RDWR, 0)) != -1) {
        dup2(fd, STDIN_FILENO);
        dup2(fd, STDOUT_FILENO);
        dup2(fd, STDERR_FILENO);
        if (fd > STDERR_FILENO) close(fd);
    }
}

Comment 1 Sebastien Pasche 2013-09-02 06:20:45 UTC
Any news ?

Comment 2 Fedora Update System 2013-09-06 10:21:05 UTC
redis-2.6.16-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/redis-2.6.16-1.fc19

Comment 3 Fedora Update System 2013-09-06 10:21:45 UTC
redis-2.6.16-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/redis-2.6.16-1.fc20

Comment 4 Fedora Update System 2013-09-06 10:22:22 UTC
redis-2.6.16-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/redis-2.6.16-1.fc18

Comment 5 Fedora Update System 2013-09-06 17:27:14 UTC
Package redis-2.6.16-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing redis-2.6.16-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-15973/redis-2.6.16-1.fc20
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2013-09-23 00:50:35 UTC
redis-2.6.16-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2013-09-30 00:30:30 UTC
redis-2.6.16-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2013-11-02 04:54:46 UTC
redis-2.6.16-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.