Bug 974134

Summary: Review Request: idlj-maven-plugin - The CORBA IDL Compiler Maven Plugin
Product: [Fedora] Fedora Reporter: Marek Goldmann <mgoldman>
Component: Package ReviewAssignee: gil cattaneo <puntogil>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, puntogil
Target Milestone: ---Flags: puntogil: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-06-21 13:00:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marek Goldmann 2013-06-13 13:44:28 UTC
Spec URL: http://goldmann.fedorapeople.org/package_review/idlj-maven-plugin/1/idlj-maven-plugin.spec
SRPM URL: http://goldmann.fedorapeople.org/package_review/idlj-maven-plugin/1/idlj-maven-plugin-1.2.1-1.fc19.src.rpm
Fedora Account System Username: goldmann

Description:

The CORBA IDL Compiler Maven Plugin is used for processing IDL files into java sources.

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5499152

Comment 1 gil cattaneo 2013-06-13 13:55:25 UTC
hi,
source code is available also here:
http://repo2.maven.org/maven2/org/codehaus/mojo/idlj-maven-plugin/1.2.1/idlj-maven-plugin-1.2.1-source-release.zip
regards

Comment 2 gil cattaneo 2013-06-13 13:58:50 UTC
hi,
build fails:
fedora-review -b 974134 -m fedora-rawhide-i386

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.012s
[INFO] Finished at: Thu Jun 13 15:55:50 CEST 2013
[INFO] Final Memory: 15M/134M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project idlj-maven-plugin: Could not resolve dependencies for project org.codehaus.mojo:idlj-maven-plugin:maven-plugin:1.2.1: The repository system is offline but the artifact avalon:avalon-logkit:jar:1.2 is not available in the local repository. -> [Help 1]

please add bR mvn(avalon:avalon-logkit)
regards

Comment 3 gil cattaneo 2013-06-13 14:00:06 UTC
ops
sorry i dont see avalon is already a BR

Comment 4 Marek Goldmann 2013-06-13 14:02:38 UTC
Make sure you use the latest jacorb from Rawhide: jacorb-2.3.1-6.fc20 which fixes it. See scratch build.

Comment 5 gil cattaneo 2013-06-13 14:21:34 UTC
hi,
isnt again available
downloaded jacorb-2.3.1-5.fc20.noarch
Manual review:


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
     Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in idlj-maven-
     plugin-javadoc
     IGNORE
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "Unknown or generated". 11 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
     Note: Using prebuilt packages
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It is
     pulled in by maven-local
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build

Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
     when building with ant
[x]: If tests are skipped during package build explain why it was needed in a
     comment
     Note: Tests seem to be skipped. Verify there is a commment giving a
     reason for this
[x]: Pom files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: idlj-maven-plugin-1.2.1-1.fc20.noarch.rpm
          idlj-maven-plugin-javadoc-1.2.1-1.fc20.noarch.rpm
idlj-maven-plugin.noarch: E: description-line-too-long C The CORBA IDL Compiler Maven Plugin is used for processing IDL files into java sources.
idlj-maven-plugin-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados
2 packages and 0 specfiles checked; 1 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint idlj-maven-plugin idlj-maven-plugin-javadoc
idlj-maven-plugin.noarch: E: description-line-too-long C The CORBA IDL Compiler Maven Plugin is used for processing IDL files into java sources.
idlj-maven-plugin-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados
2 packages and 0 specfiles checked; 1 errors, 1 warnings.
# echo 'rpmlint-done:'



Requires
--------
idlj-maven-plugin (rpmlib, GLIBC filtered):
    java
    jpackage-utils
    mvn(org.apache.maven:maven-model)
    mvn(org.apache.maven:maven-plugin-api)
    mvn(org.apache.maven:maven-project)
    mvn(org.codehaus.plexus:plexus-compiler-api)
    mvn(org.codehaus.plexus:plexus-utils)
    mvn(org.jacorb:jacorb-idl-compiler)

idlj-maven-plugin-javadoc (rpmlib, GLIBC filtered):
    jpackage-utils



Provides
--------
idlj-maven-plugin:
    idlj-maven-plugin
    mvn(org.codehaus.mojo:idlj-maven-plugin)

idlj-maven-plugin-javadoc:
    idlj-maven-plugin-javadoc



Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29
Buildroot used: fedora-18-i386
Command line :/usr/bin/fedora-review -vpn idlj-maven-plugin

Comment 6 gil cattaneo 2013-06-13 14:24:02 UTC
approved

Comment 7 Marek Goldmann 2013-06-14 13:47:12 UTC
Thanks for the review!

New Package SCM Request
=======================
Package Name: idlj-maven-plugin
Short Description: The CORBA IDL Compiler Maven Plugin
Owners: goldmann

Comment 8 Gwyn Ciesla 2013-06-14 14:08:30 UTC
Git done (by process-git-requests).