Bug 974716

Description of problem:

Service psacct.service fails to start if accounting file already exists (= after it was started at least once).

Version-Release number of selected component (if applicable):

psacct-6.6.1-2.fc19.x86_64

How reproducible:

Always after first successful run.

Steps to Reproduce:
1. run "systemctl start psacct"
2. if it is started (it should when run first time after installation), stop it and try to start again
3. check the result

Actual results:

Job for psacct.service failed. See 'systemctl status psacct.service' and 'journalctl -xn' for details.

And from systemctl status:

# systemctl status psacct.service
psacct.service - Kernel process accounting
   Loaded: loaded (/usr/lib/systemd/system/psacct.service; enabled)
   Active: failed (Result: exit-code) since Sat 2013-06-15 01:32:57 CEST; 6s ago
  Process: 1664 ExecStop=/usr/sbin/accton off (code=exited, status=0/SUCCESS)
  Process: 1654 ExecStart=/usr/sbin/accton /var/account/pacct (code=exited, status=0/SUCCESS)
  Process: 1669 ExecStartPre=/usr/libexec/psacct/accton-create (code=exited, status=1/FAILURE)

Jun 15 01:32:57 localhost.localdomain systemd[1]: psacct.service: control process exited, code=exited status=1
Jun 15 01:32:57 localhost.localdomain systemd[1]: Failed to start Kernel process accounting.
Jun 15 01:32:57 localhost.localdomain systemd[1]: Unit psacct.service entered failed state.

Expected results:

Process accounting is started.

Additional info:

It seems that the problem is in /usr/libexec/psacct/accton-create script:

--snip--
#!/bin/sh
ACCTFILE=/var/account/pacct
[ ! -r $ACCTFILE ] && touch $ACCTFILE && chmod 600 $ACCTFILE
--snip--

Obviously, when accounting file already exists, the script will exit with non-zero status, which is propagated to systemd, thus reporting (incorrectly) failure.

Actually, "[ ! -r $ACCTFILE ] && " is not needed at all, as touch will try to create file if it doesn't exist, and chmod won't hurt in any case.