Bug 974784
| Summary: | live image composing in koji broken | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Fenzi <kevin> |
| Component: | livecd-tools | Assignee: | Brian Lane <bcl> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 19 | CC: | adam.stokes, awilliam, bcl, bruno, dhuff, itamar, Jasper.Hartline, katzj, lkundrak, nphilipp, robatino, shpnft, twoerner |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | AcceptedBlocker | ||
| Fixed In Version: | livecd-tools-19.5-1.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-06-20 05:58:31 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 834090 | ||
|
Description
Kevin Fenzi
2013-06-15 19:43:09 UTC
Nominating for a final blocker on the basis of us not being able to compose live images would make testing them difficult. ;) the thing at fault here is system-config-keyboard. adam added a patch to configure localed, its added a dep on dbus. so we either need to make system-config-keyboard not need dbus or we need to change how keyboards are configured. the patch came from vpodzime, but it's, well, it's correct. keyboard configuration should be done through localed now. that's how it's supposed to work. you might ask lennart / kay if they have any thoughts on how to make this fly. why does the live compose process need to do anything with keyboards anyway? btw, it can't be particularly important, because s-c-k has been broken throughout the entire f18 and f19 cycles until now. it was not capable of actually setting systemwide keyboard configurations. Suggestion: simply comment out all the 'keyboard us' lines in spin-kickstarts. I can see no reason why we actually need to explicitly set the layout which is in any case the default, during live compose. Re-assigning to livecd-tools. system-config-keyboard is not doing anything wrong here. The current design of this subsystem is that systemd-localed is the broker for setting keyboard configuration: the correct way to configure the keyboard is to ask localed to do it. It would be inappropriate to change s-c-keyboard to do it any other way. The fact that this doesn't work in the live compose environment is a problem of the live compose tools and/or environment, not s-c-k. We have several options here. 1. We could simply drop the ability to change keyboard layout for live images: it seems to be rarely used anyway (or someone would've complained at some point since it was broken in Fedora 18). Spin maintainers might be able to do it if they really want to by adding a localectl call to the 'livesys' script or something. 2. We could hack python-imgcreate to write a kbd layout name directly to /etc/vconsole.conf and depend on systemd-localed to translate that into an X layout during boot. This might work, but it's a trifle inelegant. 3. We could fix up the live image creation process such that this works - use livemedia-creator and do it in a VM, or whatever. I don't know. But s-c-keyboard is not broken, here. Discussed at 2013-06-17 blocker review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2013-06-17/f19final-blocker-review-6.2013-06-17-16.01.log.txt . Accepted as a blocker as it prevents live image compose (could have been an automatic blocker). livecd-tools-19.5-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/livecd-tools-19.5-1.fc19 Note that this patch writes out vconsole.conf but that doesn't seem to have any effect on the keyboard in my minimal tests. It does fix the traceback, but keyboard support is going to need something else. For the problem with the config apparently not being set, see https://bugzilla.redhat.com/show_bug.cgi?id=975238 - I traced it out a bit more, but not fully. I think python-imgcreate is now doing the right thing, though. Package livecd-tools-19.5-1.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing livecd-tools-19.5-1.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-11179/livecd-tools-19.5-1.fc19 then log in and leave karma (feedback). 19.5 clearly fixes the bug, or else we wouldn't have TC5 lives. livecd-tools-19.5-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. Any chance that this patch be applied in the f18? |