Bug 974934

Summary: Disable Selinux will cause unexpected error.
Product: [Retired] oVirt Reporter: Yaning Wang <yaniwang>
Component: ovirt-nodeAssignee: Joey Boggs <jboggs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: acathrow, fdeutsch, hadong, jboggs, leiwang, mburns, mgoldboi, ovirt-bugs, ovirt-maint, ycui
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-node-3.0.3 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-28 13:51:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yaning Wang 2013-06-17 07:47:44 UTC
Description of problem:

When use `edit-node` to install additional package into ovirt-node image and selinux in `disable` state.

A `OSError` will occur and block the operation.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:

1. 'SELINUX=DISABLED' in /etc/sysconfig/selinux
2. $ edit-node --repo=repo --install=some-package ovirt-node.iso

Actual results:

OSError will occur.

Expected results:

`selinux.security_getenforce()` this fucntion will throw OSError when selinux disabled. I think this error should be captured and give appropriate warning message instead breaking the process, in some case user need to disable the selinux.

Additional info:

Comment 1 haiyang,dong 2013-06-17 08:54:42 UTC
Catch the OSError when Set "SELinux" disabled:
http://gerrit.ovirt.org/#/c/15786/

Comment 2 Fabian Deutsch 2013-11-28 13:51:19 UTC
This should be fixed in recent edit-node versions