Bug 975313
| Summary: | Review Request: libodb-boost - Boost ODB runtime library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dave Johansen <davejohansen> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | besser82, boris, lemenkov, notting, package-review |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libodb-boost-2.2.1-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-11-09 03:29:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 975312 | ||
| Bug Blocks: | |||
|
Description
Dave Johansen
2013-06-18 05:04:09 UTC
Unblocking FE-NEEDSPONSOR - I've just sponsored Dave. The updated files can be found at: Spec URL: http://daveisfera.fedorapeople.org/odb_2.2/specs/libodb-boost.spec SRPM URL: http://daveisfera.fedorapeople.org/odb_2.2/SRPMS/libodb-boost-2.2.1-1.fc19.src.rpm This package is ready to review and a scratch build against rawhide is available at: http://koji.fedoraproject.org/koji/taskinfo?taskID=6028284 Sorry, I forgot to include the link to the current source RPM in the last comment. It can be found at: http://daveisfera.fedorapeople.org/odb_2.2/SRPMS/libodb-boost-2.2.1-1.el6.src.rpm Looks good. Here is my formal
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is silent
work ~/Desktop: rpmlint libodb-boost-*
libodb-boost.src: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment
libodb-boost.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment
^^^ False positives.
libodb-boost.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 3 warnings.
work ~/Desktop:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
+ The License field in the package spec file matches the actual license (strict GPLv2).
+ The file, containing the text of the license(s) for the package, is included in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The package successfully compiles and builds into binary rpms on at least one primary architecture. See Koji link above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
+ The package stores shared library files in some of the dynamic linker's default paths, and it calls ldconfig in %post and %postun.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the application. Well, since we're moving to unversioned docdirs this will definitely cause issues. Please be careful with EL5 and EL6.
+ Header files are stored in a -devel package.
0 No static libraries.
+ The pkgconfig(.pc) files are stored in a -devel package. A necessary runtime requirement is picked up automatically in Fedora, but EL5 (and maybe even EL6) will require explicit "Requires: pkgconfig"
+ The library file(s) that end in .so (without suffix) is(are) stored in a -devel package.
+ The -devel package requires the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
APPROVED.
New Package SCM Request ======================= Package Name: libodb-boost Short Description: Boost ODB runtime library from Code Synthesis Owners: daveisfera Branches: el5 el6 f18 f19 f20 InitialCC: peter Git done (by process-git-requests). libodb-boost-2.2.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libodb-boost-2.2.1-1.fc18 libodb-boost-2.2.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libodb-boost-2.2.1-1.fc19 libodb-boost-2.2.1-1.fc19 has been pushed to the Fedora 19 testing repository. libodb-boost-2.2.1-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/libodb-boost-2.2.1-1.el5 libodb-boost-2.2.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libodb-boost-2.2.1-1.el6 libodb-boost-2.2.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/libodb-boost-2.2.1-1.fc20 libodb-boost-2.2.1-1.fc19 has been pushed to the Fedora 19 stable repository. libodb-boost-2.2.1-1.fc18 has been pushed to the Fedora 18 stable repository. libodb-boost-2.2.1-1.fc20 has been pushed to the Fedora 20 stable repository. libodb-boost-2.2.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository. libodb-boost-2.2.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |