Bug 975472

Summary: Windows virt-viewer should ignore trailing '/' for SpiceProxyDefault value
Product: Red Hat Enterprise Virtualization Manager Reporter: Jiri Belka <jbelka>
Component: mingw-virt-viewerAssignee: Marc-Andre Lureau <marcandre.lureau>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.3.0CC: acathrow, cfergeau, dblechte, djasa, marcandre.lureau
Target Milestone: ---   
Target Release: 3.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: mingw-spice-gtk-0.20-1.el6_4 Doc Type: Bug Fix
Doc Text:
virt-viewer did not accept proxy URLs ending with a '/' symbol. If proxy was specified in such a way, virt-viewer would not be able to use it. To fix this issue, virt-viewer now removes trailing / from proxy URLs, so proxy URLs with or without trailing / can be used.
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-21 14:46:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jiri Belka 2013-06-18 14:29:11 UTC
Description of problem:
Usual way people define value for http proxy, like http_proxy env variable read by many many cli tools on Linux, is in the way:

* http://fqdn:port

or

* http://fqdn:port/

(fqdn can be replaced by resolvable name or with an IP)

Anyway, virt-viewer does _NOT_ use http proxy when it gets spice proxy value with trailing '/'. This is very annoying.



Version-Release number of selected component (if applicable):
sf18 - 0.5.3

How reproducible:
100%

Steps to Reproduce:
1. have SpiceProxyDefault without trailing '/'
2. open console
3. have SpiceProxyDefault with trailing '/'
4. open console

Actual results:
4. does not even try to use proxy, it just uses direct connection

Expected results:
work as many other apps/tools

Additional info:

Comment 1 Marc-Andre Lureau 2013-06-18 14:59:39 UTC
I wonder if there is any spec for this...

Anyway, here is the patch:
http://lists.freedesktop.org/archives/spice-devel/2013-June/013679.html

Comment 2 David Jaša 2013-07-19 15:09:26 UTC
confirmed on mingw-virt-viewer-0.5.3-28 -> qa_ack+

Comment 5 Charlie 2013-11-28 01:27:46 UTC
This bug is currently attached to errata RHEA-2013:15512. If this change is not to be documented in the text for this errata please either remove it from the errata, set the requires_doc_text flag to 
minus (-), or leave a "Doc Text" value of "--no tech note required" if you do not have permission to alter the flag.

Otherwise to aid in the development of relevant and accurate release documentation, please fill out the "Doc Text" field above with these four (4) pieces of information:

* Cause: What actions or circumstances cause this bug to present.
* Consequence: What happens when the bug presents.
* Fix: What was done to fix the bug.
* Result: What now happens when the actions or circumstances above occur. (NB: this is not the same as 'the bug doesn't present anymore')

Once filled out, please set the "Doc Type" field to the appropriate value for the type of change made and submit your edits to the bug.

For further details on the Cause, Consequence, Fix, Result format please refer to:

https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes 

Thanks in advance.

Comment 7 errata-xmlrpc 2014-01-21 14:46:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0034.html