Bug 976299

Summary: mke2fs-J should give a meaningful error when specified type is anything except 'ext{2,3,4}'
Product: Red Hat Enterprise Linux 7 Reporter: bfan
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.0CC: leiwang, wshi
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libguestfs-1.22.4-1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 978302 (view as bug list) Environment:
Last Closed: 2014-06-13 11:05:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 978302    
Bug Blocks:    

Description bfan 2013-06-20 10:14:25 UTC
Description of problem:
For example,
mke2fs doesn't support xfs, it should give a meaningful error message when you specified xfs, but not gives ext3 


Version-Release number of selected component (if applicable):
libguestfs-1.22.2-1.el7.x86_64

How reproducible:
100%


Steps to Reproduce:
1. create a disk with xfs
[root]# guestfish -N fsfs
><fs> quit

2.
[root]# eval `guestfish --listen`
[root]# guestfish --remote -x -- -add test1.img
[root]# guestfish --remote -x -- -alloc journalname 50M
[root]# guestfish --remote -x -- -run
[root]# guestfish --remote -- -mke2journal 1024  /dev/sdb
[root]# guestfish --remote -- -mke2fs-J xfs 1024 /dev/sda /dev/sdb
[root]# vfs_type=`guestfish --remote -- -vfs-type /dev/sda`
[root]# echo $vfs_type
ext3


Actual results:
Got ext3 type


Expected results:
Give a error message

Additional info:

Comment 1 Richard W.M. Jones 2013-06-26 10:13:27 UTC
One line reproducer:

$ guestfish -N part -N part mke2journal 1024 /dev/sda1 : mke2fs-J xfs 1024 /dev/sdb1 /dev/sda1
$ echo $?
0

The mke2fs-J command should give an error instead of succeeding.

Comment 4 bfan 2013-12-02 05:24:48 UTC
Verified with libguestfs-1.22.6-16.el7.x86_64

# guestfish -N part -N part mke2journal 1024 /dev/sda1 : mke2fs-J xfs 1024 /dev/sdb1 /dev/sda1
libguestfs: error: mke2fs_J: xfs: not a valid extended filesystem type

Comment 5 Ludek Smid 2014-06-13 11:05:19 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.