Bug 976442
| Summary: | Review Request: bugwarrior - Sync github, bitbucket, and trac issues with taskwarrior | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Patrick Uiterwijk <puiterwijk> |
| Component: | Package Review | Assignee: | Marcelo Barbosa "firemanxbr" <marcelo.barbosa> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | crobinso, echevemaster, i, marcelo.barbosa, package-review, puiterwijk |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-02-26 15:28:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Patrick Uiterwijk
2013-06-20 14:59:02 UTC
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5524272 This will require some additional deps to be packaged, I will post the bugzilla ids here for them Patrick, I can review for you, but what's your FAS ? Marcelo Barbosa Hi Marcelo, My FAS username is puiterwijk. Thanks in advance for the review! Regarding the deps: They are not actually required to run the program, but are required for some of the backends supported. (so if you do not meet the deps, you just can't use those backends) Patrick,
Please see this is issues:
[!]: %check is present and all tests pass.
[!]: A package which is used by another package via an egg interface should
provide egg info.
[!]: Package meets the Packaging Guidelines::Python
Legend: [!] = Fail
Reference: http://fedoraproject.org/wiki/Packaging:Python
Marcelo Barbosa
(In reply to Marcelo Barbosa from comment #5) > Patrick, > > Please see this is issues: > > [!]: %check is present and all tests pass. I don't see any test in the package, Marcelo. > [!]: A package which is used by another package via an egg interface > should > provide egg info. @Patrick, please remove the eggs in %prep as well: %prep %setup -q # Remove bundled egg-info rm -rf foo-info and list the egg-info in a more verbose %{python_sitelib}/foo %{python_sitelib}/foo-*.egg-info - this is not arched package, the CFLAGS not are necessary the package is made in python, usually on Fedora we naming the python package with the prefix *python you can use %global pkgname bugwarrior and naming the package as well Name: python-bugwarrior by example, see: http://pkgs.fedoraproject.org/cgit/python-django-select2.git/tree/python-django-select2.spec The package requires: "twiggy", "bitlyapi",=> is on Fedora $ repoquery --provides python-bitlyapi python-bitlyapi = 0.1.1-3.fc19 "requests",is on Fedora $repoquery --provides python-requests python-requests = 1.1.0-4.fc19 "offtrac", Is on Fedora $repoquery --provides python-offtrac python-offtrac = 0.0.4-1.fc19 "python-bugzilla", is on Fedora repoquery --provides python-bugzilla python-bugzilla = 0.9.0-1.fc19 "jira-python", is on Fedora "taskw >= 0.4.2", repoquery --provides python-taskw python-taskw = 0.4.3-3.fc19 "dogpile.cache", is on Fedora repoquery --provides python-dogpile-cache python-dogpile-cache = 0.4.2-2.fc19 Please add in the requires > [!]: Package meets the Packaging Guidelines::Python > > Legend: [!] = Fail > > Reference: http://fedoraproject.org/wiki/Packaging:Python > > Marcelo Barbosa Looks like bugwarrior is already in fedora: https://admin.fedoraproject.org/pkgdb/acls/name/bugwarrior So closing this |