Bug 976453

Summary: Missing gpg feature
Product: [Fedora] Fedora Reporter: Ulrich Drepper <drepper.fsp+rhbz>
Component: fwknopAssignee: Jakub Jelen <jjelen>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 20CC: bugzilla.30.miller_2555, drepper, extras-qa, jjelen, pvrabec, thebenj88
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: fwknop-2.6.5-2.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-06-05 23:55:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ulrich Drepper 2013-06-20 15:25:19 UTC
Description of problem:
fwknop has support for GPG keys by using the gpgme package.  The problem is that the .spec file in the current version doesn't have gpgme-devel as a BuildRequire and therefore the configure script won't find the library.

Version-Release number of selected component (if applicable):
2.0.4-1

How reproducible:
always

Steps to Reproduce:
1.set up fwknop with gpg keys
2.try to use it
3.

Actual results:
Error message about unsupported feature

Expected results:
Working gpg support

Additional info:

In lib/fko_encryption.c in function fko_set_gpg_recipient (among others) there is #ifdef HAVE_LIBGPGME.  Just adding

BuildRequires: gpgme-devel

fixes this.

Comment 1 Ulrich Drepper 2013-11-01 21:52:29 UTC
Could you please just add the one little change?  It still is broken in F20.  If the problem is that I did not provide a patch let me know.  But it's really just a matter of adding gpgme-devel to the BuildRequires line.

Comment 2 Ulrich Drepper 2013-12-01 17:10:47 UTC
Still not done, I once again had to compile the version myself.  It's a really simple change.  Do you have a problem with this?  Is the build environment even more restricted?  Maybe in addition to gpgme-devel you also have to add gpg.  So:

-BuildRequires: libpcap-devel iptables systemd
+BuildRequires: libpcap-devel iptables systemd gpgme-devel gpg

Comment 3 Ben Reedy 2014-10-25 17:40:44 UTC
Bug is still occurring as of version 2.5.1-1.fc20
GPG functionality worked after adding Ulrich's fix to the spec file and building myself.

Comment 4 bugzilla.30.miller_2555 2015-03-12 01:35:11 UTC
Ditto on this -- still outstanding in F22, and fix doesn't appear in rawhide. Since still marked "NEW', maybe it was just lost in the shuffle -- is Jakub the appropriate assignee (to QA)? Thx

Comment 5 Jakub Jelen 2015-04-07 11:13:52 UTC
Sorry, I did miss this bugzilla during last update(s).

I pushed this feature into rawhide and will be glad for some testing if it does what it should.
http://koji.fedoraproject.org/koji/taskinfo?taskID=9427870

If so, please let me know that I can post it also into other branches. I tested only basic functionality.

Comment 6 Fedora Update System 2015-05-25 14:40:44 UTC
fwknop-2.6.5-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/fwknop-2.6.5-2.fc22

Comment 7 Fedora Update System 2015-05-25 15:22:19 UTC
fwknop-2.6.5-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/fwknop-2.6.5-2.fc21

Comment 8 Fedora Update System 2015-05-26 11:37:25 UTC
fwknop-2.6.5-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/fwknop-2.6.5-2.el7

Comment 9 Ulrich Drepper 2015-05-26 13:18:19 UTC
I can confirm it works now.  Tested on F22.

Comment 10 Fedora Update System 2015-05-26 21:27:33 UTC
Package fwknop-2.6.5-2.el7:
* should fix your issue,
* was pushed to the Fedora EPEL 7 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing fwknop-2.6.5-2.el7'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-6411/fwknop-2.6.5-2.el7
then log in and leave karma (feedback).

Comment 11 Fedora End Of Life 2015-05-29 09:08:05 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 12 Fedora Update System 2015-06-05 23:55:11 UTC
fwknop-2.6.5-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2015-06-06 00:02:53 UTC
fwknop-2.6.5-2.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2015-06-10 19:16:21 UTC
fwknop-2.6.5-2.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Red Hat Bugzilla 2023-09-14 01:46:54 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days