Bug 976919
Summary: | gnome-desktop-testing - a simple test runner for installed tests | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matthias Clasen <mclasen> |
Component: | Package Review | Assignee: | Michael Schwendt <bugs.michael> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 19 | CC: | notting, package-review |
Target Milestone: | --- | Flags: | bugs.michael:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-07-12 18:08:06 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Matthias Clasen
2013-06-21 21:57:57 UTC
There's not much to review here, so only very minor issues. The linked spec file is newer than what's included in the src.rpm. It removes the libtool archive. $ rpmlint * gnome-desktop-testing.x86_64: E: incorrect-fsf-address /usr/share/doc/gnome-desktop-testing-2013.1/COPYING gnome-desktop-testing.x86_64: W: no-manual-page-for-binary gnome-desktop-testing-runner gnome-desktop-testing-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/gnome-desktop-testing-2013.1/src/gnome-desktop-testing-runner.c => https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address The exe-perm should be removed in upstream tarball release, too. > Summary: A test runner for installed tests That's *very* generic. In this case it wouldn't hurt to mention the relationship to the GNOME project, e.g. Summary: GNOME's test runner for installed tests Btw, typically, the leading articles (such as "A", "An", "The") don't look good in package tools or Anaconda. * Who will own the default directory /usr/share/installed-tests? The individual packages that store .test files somewhere below that dir? Will there be dependencies on this package? https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership All issues are no blockers and could be fixed in Fedora package git. APPROVED New Package SCM Request ======================= Package Name: gnome-desktop-testing-runner Short Description: GNOME test runner for installed tests Owners: mclasen,walters Branches: InitialCC: Review bug package name and SCM package name don't match. Also, user FAS names, not email addresses. New Package SCM Request ======================= Package Name: gnome-desktop-testing Short Description: GNOME test runner for installed tests Owners: mclasen walters Branches: InitialCC: Git done (by process-git-requests). |