Bug 977156

Summary:	Code to return
Product:	[Fedora] Fedora	Reporter:	MERCIER Jonathan <bioinfornatics>
Component:	rpmlint	Assignee:	Tom "spot" Callaway <tcallawa>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	18	CC:	a.badger, manuel.wolfshant, tcallawa, tmz, twoerner, ville.skytta
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-06-25 20:46:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description MERCIER Jonathan 2013-06-23 22:15:29 UTC

why rpmdiff return 1 when it found a diff ?

The return code 1 is used for error.

a diff is not an error


this break my worklow as trap exit on error aka exit code 1

Comment 1 Todd Zullinger 2013-06-24 00:08:25 UTC

This is the standard way that diff behaves.  To quote the diff documentation¹, "An exit status of 0 means no differences were found, 1 means some differences were found, and 2 means trouble."

I don't think there is any bug in rpmdiff following the same pattern.

¹ https://www.gnu.org/software/diffutils/manual/html_node/Invoking-diff.html

Comment 2 MERCIER Jonathan 2013-06-25 20:46:50 UTC

ok no problem if that is intentional i can understand why you done this.

Thanks