Bug 977246

Summary: Hostnames with double dots are not caught during set validation
Product: [Community] GlusterFS Reporter: Kaushal <kaushal>
Component: cliAssignee: Kaushal <kaushal>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: gluster-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.4.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-24 17:09:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 974393    

Description Kaushal 2013-06-24 07:11:54 UTC
Description of problem:
Hostnames with double dots in them, for eg. 'example..com' are not caught during volume set option validation.

Version-Release number of selected component (if applicable):
master

How reproducible:
Always

Steps to Reproduce:
1. set 'example..org' as the auth.{allow or reject} address

Actual results:
# gluster volume set test auth.reject example..org
volume set: success

Expected results:
# gluster volume set test auth.reject example..org
volume set: failed: option auth.addr./brick/test.reject example..org: 'example..org' is not a valid internet-address-list

Additional info:

Comment 1 Anand Avati 2013-06-24 07:35:13 UTC
REVIEW: http://review.gluster.org/5249 (libglugsterfs: Fix valid_host_name for consecutive dots) posted (#1) for review on master by Kaushal M (kaushal)

Comment 2 Anand Avati 2013-06-24 07:43:04 UTC
REVIEW: http://review.gluster.org/5249 (libglusterfs: Fix valid_host_name for consecutive dots) posted (#2) for review on master by Kaushal M (kaushal)

Comment 3 Anand Avati 2013-06-24 10:53:45 UTC
REVIEW: http://review.gluster.org/5249 (libglusterfs: Fix valid_host_name for consecutive dots) posted (#3) for review on master by Kaushal M (kaushal)

Comment 4 Anand Avati 2013-06-25 04:21:09 UTC
REVIEW: http://review.gluster.org/5249 (libglusterfs: Fix valid_host_name for consecutive dots) posted (#4) for review on master by Kaushal M (kaushal)

Comment 5 Anand Avati 2013-07-02 09:58:37 UTC
COMMIT: http://review.gluster.org/5249 committed in master by Vijay Bellur (vbellur) 
------
commit 7062eda1575214819f5c7411748b06be95e08ffa
Author: Kaushal M <kaushal>
Date:   Mon Jun 24 12:50:32 2013 +0530

    libglusterfs: Fix valid_host_name for consecutive dots
    
    The valid_host_name() function must reject addresses with consecutive
    dots in them.
    
    Change-Id: I1749de80c66e8fbad63b2e014f79e0203906030e
    BUG: 977246
    Signed-off-by: Kaushal M <kaushal>
    Reviewed-on: http://review.gluster.org/5249
    Reviewed-by: Amar Tumballi <amarts>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>