Bug 977562

Summary:	Queued recipes that only have 'Broken' systems available to them, will never progress.
Product:	[Retired] Beaker	Reporter:	Raymond Mancy <rmancy>
Component:	scheduler	Assignee:	Raymond Mancy <rmancy>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	0.12	CC:	aigao, asaha, dcallagh, ebaak, llim, qwan, rmancy, xjia
Target Milestone:	0.14.2	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-11-07 01:47:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Raymond Mancy 2013-06-24 22:52:12 UTC

Description of problem:

If all of the systems available to a queued recipe are marked 'Broken' after
the recipe is queued but before it is scheduled, the recipe will never progress.

Version-Release number of selected component (if applicable):


How reproducible:

Always

Steps to Reproduce:
1. Queue two recipes that both use the same system.
2. When R1 is running and R2 queued, mark R1's system as broken.
3. Cancel R1


Actual results:

R2 remains queued

Expected results:

R2 should abort

Additional info:

This is because schedule_queued_recipes() only considers recipes that have systems that are 'Automated'.

One way to deal with this, would be to remove the system status check in the query, and then just deal with broken systems the same way we deal with systems that the user no longer has permission with. In this way, the system would be removed and picked up by abort_dead_recipes()

Comment 1 Nick Coghlan 2013-06-25 07:22:47 UTC

Will we also hit this if a recipe is queued while an automated system is on loan, but extra restrictions (like shared=False or a group setting) are added before the loan is released?

Comment 2 Raymond Mancy 2013-06-25 07:28:13 UTC

If the loan is returned the system will then become available for the recipe. Before the recipe is actually scheduled though, it checks whether it still has the correct permissions for this system. If it does not, it is removed as a candidate system. Once candidate systems equal zero, it is picked up by aborted_dead_recipes()

Comment 3 Raymond Mancy 2013-06-27 05:56:16 UTC

http://gerrit.beaker-project.org/#/c/2064/

Comment 5 Raymond Mancy 2013-09-19 06:50:10 UTC

Steps to reproduce:

1. Queue two recipes, both useing the one same system
2. R1 will start and R2 will be queued
3. Then set that status of the system to Broken
4. Cancel R1
5. R2 should not remain queued, but should become Aborted

Comment 6 Raymond Mancy 2013-09-19 06:50:37 UTC

^ Steps to verify fix rather.

Comment 8 Nick Coghlan 2013-10-03 02:28:30 UTC

Beaker 0.15 has been released.

Comment 9 Raymond Mancy 2013-10-23 01:57:04 UTC

This change has been nominated to be back ported to the 0.14 branch, to be released as part of the next maintenance release 0.14.2.

Comment 10 Nick Coghlan 2013-10-25 06:36:08 UTC

Adjusting target milestone to make the changes backported to 0.14.2 easier to identify. 0.15.0 has enough significant regressions that it shouldn't be used, so the change means that 0.15.1 can be effectively reidentified as the union of that tag and the 0.14.2 target milestone.

Comment 13 Nick Coghlan 2013-11-07 01:47:04 UTC

Closing as addressed in Beaker 0.14.2.