Bug 978010
| Summary: | Review Request: perl-Wx-GLCanvas - Interface to wxWidgets' OpenGL canvas | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, psabata |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Wx-GLCanvas-0.09-2.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-02 03:40:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Miro Hrončok
2013-06-25 19:31:15 UTC
Ok, the deps are all wrong :)
What you actually need to BR:
perl, perl(Exporter), perl(lib), perl(strict), perl(Wx::build::MakeMaker), and wxGTK-devel
ExtUtils::MakeMaker is only used if Wx::build::MakeMaker is not present.
Alien::wxWidgets and Wx are not required for build in your case.
I don't understand how the package builds without the wx/* files since they're all included in GLCanvas.xs. Could you explain that? Also, why do you remove the directory?
You'll need to buildrequire many more modules in the %{?with_tests} conditional block:
perl(base), lib/Wx/GLCanvas.pm:17
perl(Test::More), t/zz_pod.t:4
perl(Wx), lib/Wx/GLCanvas.pm:16
perl(Wx::ScrolledWindow), lib/Wx/GLCanvas.pm:17
Protip: You could use Test::NeedsDisplay to provide an Xvfb display for the tests, running them everywhere, every time.
https://metacpan.org/module/ADAMK/Test-NeedsDisplay-1.07/lib/Test/NeedsDisplay.pm
Sorry for the messed deps. Thanks for the protip. wx dir contains bundled things, that should be included from /usr/include/wx-2.8/wx (see -I/usr/include/wx-2.8 in spec). Spec URL: https://raw.github.com/hroncok/SPECS/master/perl-Wx-GLCanvas.spec SRPM URL: http://churchyard.fedorapeople.org/SRPMS/perl-Wx-GLCanvas-0.09-2.fc19.src.rpm I've redone BRs. The protip with Test::NeedsDisplay destroys the package. It forces the installation to use /usr/local Alright, I'm going to approve this. However, drop the Test::NeedsDisplay and xorg-x11-server-Xvfb dependencies if they don't work for you before you push this. Of course, I forgot to do that. Thanks New Package SCM Request ======================= Package Name: perl-Wx-GLCanvas Short Description: Interface to wxWidgets' OpenGL canvas Owners: churchyard Branches: f18 f19 InitialCC: perl-sig Git done (by process-git-requests). perl-Wx-GLCanvas-0.09-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Wx-GLCanvas-0.09-2.fc19 perl-Wx-GLCanvas-0.09-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Wx-GLCanvas-0.09-2.fc18 perl-Wx-GLCanvas-0.09-2.fc19 has been pushed to the Fedora 19 testing repository. perl-Wx-GLCanvas-0.09-2.fc18 has been pushed to the Fedora 18 stable repository. perl-Wx-GLCanvas-0.09-2.fc19 has been pushed to the Fedora 19 stable repository. |