Bug 978081
| Summary: | [PATCH] Add no-auto-default subpackage | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Colin Walters <walters> | ||||||||
| Component: | NetworkManager | Assignee: | Dan Williams <dcbw> | ||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | danw, dcbw, rvykydal, walters | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2013-07-26 20:33:27 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
10,000 bonus points if you can rework for the serverconf branch that just got merged upstream :) Created attachment 778390 [details]
new patch
This installs the generated server.conf, and renames the subpackage to NetworkManager-server-conf.
I installed the file as 00-server.conf and marked it %config but not (noreplace), because people shouldn't be editing it, they should be overriding it with another local file, if that's what they want. Right?
Maybe name it NetworkManager-config-server ? If we want other config packages in the future, I think it's nicer to name them config-XXX instead of XXX-config. I think the lack of (noreplace) is correct, though if this is going to be the case, I think we should put some notes into the server config file that say at least: 1) why the file should not be touched, because it will be overwritten on updates 2) how to override the specific settings I like the "-config-server" name better too. As for the other concerns...we could make the file say "Don't modify me" upstream, but honestly I'm not sure it really matters that much whether or not it's (noreplace). Created attachment 778797 [details]
updated patch
ok, this renames the package, and installs our own "custom" config file (including a "do not edit" message) rather than just copying in the one from the source tree.
Good?
Looks good to me. ok, pushed to rawhide |
Created attachment 765331 [details] Add no-auto-default subpackage Fedora is a large collection of packages, and at installation time Anaconda offers one the ability to install specific subsets of those packages. Historically, many Red Hat Enterprise Linux customers desire not to do DHCP by default on connected interfaces for server installations. But on client machines, we do expect that behavior. Because there is no way to distinguish between the major cases of client/server/server-with-desktop except via packages, this new subpackage tells NetworkManager to not do DHCP by default. The idea is we'll add this to comps for a new 'minimal-server' group. --- NetworkManager.spec | 27 ++++++++++++++++++++++++++- no-auto-default.conf | 2 ++ 2 files changed, 28 insertions(+), 1 deletions(-) create mode 100644 no-auto-default.conf