Bug 979332
| Summary: | Review Request: libpqtypes - Software extension to the PostgreSQL libpq interface | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jozef Mlich <jmlich> |
| Component: | Package Review | Assignee: | Dan Horák <dan> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hhorak, package-review, volker27 |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-01-22 08:53:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jozef Mlich
2013-06-28 09:04:11 UTC
This is my first package and you need a sponsor. I did my homework http://koji.fedoraproject.org/koji/taskinfo?taskID=5553430 The .so symlink belongs into the devel sub-package. Please include AUTHORS and ChangeLog as documentation. Commonly the %package and %description sections are all before the prep section. Your build appends -O3 to the Fedora flags. To my knowledge, that results in O3 being used. The group seems wrong to me, as this is no application. You've got two percent signs in from of description devel! Use the name and version macro in Source0 and potentially in the files section. rm -rf $RPM_BUILD_ROOT is obsolete and can be removed. I am already member of "Fedora Packager GIT Commit Group" so I do not need a sponsor. (In reply to Jozef Mlich from comment #1) > This is my first package and you need a sponsor. What's that about then? I have no idea what group that is, but I can't see it via FAS. (In reply to Volker Fröhlich from comment #4) > (In reply to Jozef Mlich from comment #1) > > This is my first package and you need a sponsor. > > What's that about then? > > I have no idea what group that is, but I can't see it via FAS. I am sorry, I am not very familiar with all processes in Fedora. I followed tutorial 'how to add new package into fedora'. My mentor in Red Hat explained me, I do not need mentor any more. I need just review for package. (In reply to Volker Fröhlich from comment #2) > The .so symlink belongs into the devel sub-package. > > Please include AUTHORS and ChangeLog as documentation. > > Commonly the %package and %description sections are all before the prep > section. > > The group seems wrong to me, as this is no application. > > You've got two percent signs in from of description devel! > > rm -rf $RPM_BUILD_ROOT is obsolete and can be removed. These should be fixed right now. > Your build appends -O3 to the Fedora flags. To my knowledge, that results in > O3 being used. I have sent this request to upstream developer. > Use the name and version macro in Source0 and potentially in the files > section. The URL (in Source 0) depends also on pgfoundry release_id. I am not sure if is good practice to use here this macro, because you can get wrong url afterwards. Your sponsor needs to be the one to review and approve your first package review request. https://fedoraproject.org/wiki/Package_Review_Process#Reviewer I've looked up your account in FAS and found Dan Horák is your sponsor. This is no full review, just a very brief look at the spec file: > Group: Development/Libraries "System Environment/Libraries" has been the group for run-time library base packages since many years. > Requires: postgresql%{?_isa} >= 8.4 https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires > %changelog https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs |