Bug 979408

Summary:	Embedding mysql cartridge misinforms user that phpmyadmin-3.4 is available
Product:	OKD	Reporter:	Luke Meyer <lmeyer>
Component:	Containers	Assignee:	Michal Fojtik <mfojtik>
Status:	CLOSED NOTABUG	QA Contact:	libra bugs <libra-bugs>
Severity:	low	Docs Contact:
Priority:	medium
Version:	2.x	CC:	bleanhar, gpei, jdetiber, jhonce, libra-onpremise-devel
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	928029	Environment:
Last Closed:	2013-10-02 15:57:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	917667

Description Luke Meyer 2013-06-28 13:05:33 UTC

+++ This bug was initially created as a clone of Bug #928029 +++

Description of problem:
When adding the mysql-5.1 cartridge to an app, a message is returned indicating you can add phpmyadmin to administer it. You can't.

Steps to Reproduce:
1. Create an app
2. rhc cartridge add mysql-5.1 -a <app>
  
Actual results:
"You can manage your new MySQL database by also embedding phpmyadmin-3.4.
The phpmyadmin username and password will be the same as the MySQL credentials above."


Expected results:
No mention of phpmyadmin unless it is actually available.

Additional info:
Message probably comes from the mysql cartridge. Not sure it's able to tell whether phpmyadmin is available.

Comment 1 Luke Meyer 2013-06-28 13:08:23 UTC

The cartridge response text (really, anything that will get back to the user) should be "skinnable" in some way; i.e. possible to override without rebuilding the cartridge.

Comment 2 Michal Fojtik 2013-08-26 14:58:25 UTC

Luke Mayer: It would be nice if we can have 'erb' templates for the messages we send back to clients. In that case they could be part of the cartridge but overridable by an env var (eg. CART_MESSAGES_DIR).

Comment 3 Jhon Honce 2013-08-26 15:40:52 UTC

The manifest already has a Suggests element.  I think the Broker/Node should orchestrate that information being provided to the developer in the future instead of the cartridge.

Comment 4 Michal Fojtik 2013-10-02 10:11:33 UTC

Jhon: Should I convert this feature request to a trello card?

Comment 5 Jhon Honce 2013-10-02 14:49:03 UTC

Yes, and close this upstream.  As a backstop, you could just update the current mysql code and not include a version number.

Comment 6 Michal Fojtik 2013-10-02 15:47:35 UTC

Trello card: https://trello.com/c/couCHWnN/298-broker-node-should-provide-the-suggest-element-to-the-user-when-adding-a-cartridge-or-creating-an-app

Mysql cartridge update will come shortly :-)

Comment 7 Michal Fojtik 2013-10-02 15:57:11 UTC

openshift-origin-cartridge-mysql/bin/install

30:client_result "You can manage your new MySQL database by also embedding phpmyadmin."
31:client_result "The phpmyadmin username and password will be the same as the MySQL credentials above."

The fix is already there, so we can close this bug.