Bug 979477
Summary: | virsh tunnelled live migrate ... not work in libvirt > 1.0.5 | ||
---|---|---|---|
Product: | [Community] Virtualization Tools | Reporter: | Reno <reno.gan> |
Component: | libvirt | Assignee: | Michal Privoznik <mprivozn> |
Status: | CLOSED NEXTRELEASE | QA Contact: | |
Severity: | urgent | Docs Contact: | |
Priority: | unspecified | ||
Version: | unspecified | CC: | acathrow, mprivozn |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-08-06 14:25:19 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Reno
2013-06-28 15:59:40 UTC
This is casued by these lines: src/qemu/qemu_migration.c-2011- if (flags & (VIR_MIGRATE_NON_SHARED_DISK | VIR_MIGRATE_NON_SHARED_INC) && src/qemu/qemu_migration.c-2012- virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_NBD_SERVER)) { src/qemu/qemu_migration.c-2013- /* TODO support NBD for TUNNELLED migration */ src/qemu/qemu_migration.c-2014- if (flags & VIR_MIGRATE_TUNNELLED) { src/qemu/qemu_migration.c-2015- virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", src/qemu/qemu_migration.c:2016: _("NBD in tunnelled migration is currently not supported")); src/qemu/qemu_migration.c-2017- goto cleanup; src/qemu/qemu_migration.c-2018- } src/qemu/qemu_migration.c-2019- cookieFlags |= QEMU_MIGRATION_COOKIE_NBD; src/qemu/qemu_migration.c-2020- priv->nbdPort = 0; src/qemu/qemu_migration.c-2021- } While we give user no ability to choose if NBD is used or not, we should be falling back to old implementation until support for NBD in tunnelled migration is implemented. Michal, Will this bug be fixed in the libvirt 1.1.1? Patch proposed upstream: https://www.redhat.com/archives/libvir-list/2013-August/msg00211.html I've just pushed the fix upstream: commit 5de58d87c863752fbcd24a9bd8c0900694b7e5a2 Author: Michal Privoznik <mprivozn> AuthorDate: Mon Aug 5 12:05:23 2013 +0200 Commit: Michal Privoznik <mprivozn> CommitDate: Tue Aug 6 16:07:57 2013 +0200 qemu_migration: Don't error on tunelled migration with --copy-storage https://bugzilla.redhat.com/show_bug.cgi?id=979477 Since 1.0.3 we are using the new way to copy non shared storage during migration (the NBD way). However, whether the new or old way is used is not controllable by user but unconditionally turned on if both sides of migration support it. Moreover, the implementation is not complete: the combination for VIR_MIGRATE_TUNNELLED flag is missing (as we need to open new port on the destination) in which case we just error out. This is a deadly combination: not letting users choose their destiny and erroring out. We should not do that but VIR_WARN and turn the NBD off instead. v1.1.1-66-g5de58d8 |