Bug 979661
| Summary: | Review Request: perl-Net-Random - A module gets random data from online sources | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Net-Random-2.22-2.fc18 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-07-15 01:01:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christopher Meng
2013-06-29 08:03:11 UTC
Review: + mock build is successful for f20 + rpmlint output on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha256sum) srpm tarball : bb8c499a3a663aa0495e8892ebd10ddc3549be8e742976014d7fb885eb278ff7 upstream tarball : bb8c499a3a663aa0495e8892ebd10ddc3549be8e742976014d7fb885eb278ff7 + License "GPLv2+ or Artistic" is valid and included in source files. + rest follows packaging guidelines + make test is successful with output All tests successful. Files=5, Tests=69, 271 wallclock secs ( 0.04 usr 0.00 sys + 2.19 cusr 0.29 csys = 2.52 CPU) + This package perl-Net-Random-2.22-1.fc20 Provides: perl(Net::Random) = 2.22 perl-Net-Random = 2.22-1.fc20 Requires: perl(Data::Dumper) perl(JSON) perl(LWP::UserAgent) perl(Sys::Hostname) perl(strict) perl(vars) suggestions: 1) Though all the tests that run are successful, I see one test got skipped due to missing BuildRequires: perl(Test::Pod::Coverage) add this to spec file 2) Remove explicitly listed Requires: from spec file as rpm should find those dependencies while installing this package. Only when rpm fails to find we need to list it explicitly. Requires: perl(Encode::Locale) >= 1.01 Requires: perl(JSON) Requires: perl(LWP::UserAgent) Requires: perl(Test::MockObject) >= 1.07 Requires: perl(Test::More) >= 0.64 3) Also, don't add hard versioned requirement in BuildRequires or Requires. so your BuildRequires should be BuildRequires: perl(Encode::Locale) BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(JSON) BuildRequires: perl(LWP::UserAgent) BuildRequires: perl(Test::MockObject) BuildRequires: perl(Test::More) NEW SOEC URL: http://cicku.me/perl-Net-Random.spec NEW SRPM URL: http://cicku.me/perl-Net-Random-2.22-2.fc20.src.rpm Looks good now. APPROVED. New Package SCM Request ======================= Package Name: perl-Net-Random Short Description: A module gets random data from online sources Owners: cicku Branches: f18 f19 InitialCC: Git done (by process-git-requests). perl-Net-Random-2.22-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Net-Random-2.22-2.fc19 perl-Net-Random-2.22-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Net-Random-2.22-2.fc18 perl-Net-Random-2.22-2.fc19 has been pushed to the Fedora 19 testing repository. perl-Net-Random-2.22-2.fc19 has been pushed to the Fedora 19 stable repository. perl-Net-Random-2.22-2.fc18 has been pushed to the Fedora 18 stable repository. |