Bug 979663
| Summary: | Review Request: perl-CPAN-FindDependencies - Find dependencies for modules on CPAN | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-CPAN-FindDependencies-2.42-2.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-07-15 00:53:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christopher Meng
2013-06-29 08:21:12 UTC
Review: + mock build is successful for f20 + rpmlint on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha256sum) srpm tarball : 2dfca4970f7e30e4e3fdb403bdad42b6afa32cf3bd4b7827ff6bf0d80c917494 upstream tarball : 2dfca4970f7e30e4e3fdb403bdad42b6afa32cf3bd4b7827ff6bf0d80c917494 - License "GPL+ or Artistic" is not exactly valild + rest follows packaging guidelines + make test is successful with output All tests successful. Files=8, Tests=23, 34 wallclock secs ( 0.05 usr 0.01 sys + 8.30 cusr 0.31 csys = 8.67 CPU) + This package perl-CPAN-FindDependencies-2.42-1.fc20.noarch Provides: perl(CPAN::FindDependencies) = 2.42 perl(CPAN::FindDependencies::Dependency) = 2.1 perl(CPAN::FindDependencies::MakeMaker) = 0.3 perl-CPAN-FindDependencies = 2.42-1.fc20 Requires: /usr/bin/perl perl(CPAN::FindDependencies::Dependency) perl(CPAN::FindDependencies::MakeMaker) perl(Capture::Tiny) perl(Config) perl(Cwd) perl(Exporter) perl(File::Temp) perl(LWP::UserAgent) perl(Module::CoreList) perl(Parse::CPAN::Packages) perl(Scalar::Util) perl(YAML::Tiny) perl(constant) perl(strict) perl(vars) suggestions: 1) Like suggested in other reviews, we don't need to list explicitly Requires. Also, package should not be hard versioned dependent. 2) License should be "GPLv2+ or Artistic" 3) You may want to add following for skipped test BuildRequires: perl(Test::Pod::Coverage) Note: Its not mandatory to add above BR: its just suggestion like given in other package reviews of me. See more https://fedoraproject.org/wiki/Packaging:Perl#When_to_.2Anot.2A_test NEW SPEC URL: http://cicku.me/perl-CPAN-FindDependencies.spec NEW SRPM URL: http://cicku.me/perl-CPAN-FindDependencies-2.42-2.fc20.src.rpm Looks good now. APPROVED. New Package SCM Request ======================= Package Name: perl-CPAN-FindDependencies Short Description: Find dependencies for modules on CPAN Owners: cicku Branches: f18 f19 InitialCC: Git done (by process-git-requests). perl-CPAN-FindDependencies-2.42-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-CPAN-FindDependencies-2.42-2.fc19 perl-CPAN-FindDependencies-2.42-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-CPAN-FindDependencies-2.42-2.fc18 perl-CPAN-FindDependencies-2.42-2.fc18 has been pushed to the Fedora 18 testing repository. perl-CPAN-FindDependencies-2.42-2.fc18 has been pushed to the Fedora 18 stable repository. perl-CPAN-FindDependencies-2.42-2.fc19 has been pushed to the Fedora 19 stable repository. |