Bug 979676
| Summary: | Review Request: perl-Test-TrailingSpace - Test for trailing space in source files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Test-TrailingSpace-0.0203-1.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-10 20:09:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 979674 | ||
| Bug Blocks: | 979677 | ||
|
Description
Christopher Meng
2013-06-29 10:23:08 UTC
hmm spec link and srpm link is different.... Oh...Too many perl pkgs here... ;) Spec URL: http://cicku.me/perl-Test-TrailingSpace.spec SRPM URL: http://cicku.me/perl-Test-TrailingSpace-0.0203-1.fc20.src.rpm Still I am getting in local mock build Error: No Package found for perl(File::Find::Object::Rule) so, waiting for this package. But, anyway I can review this using koji scratch build. Review: + koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=5607384 + rpmlint on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + license is "MIT" and included in source file. + Source verified with upstream as srpm tarball : e81787f1fad34093d8e19f26ae8a5cfcf658ff577ba010a40a586fa4237f9ed2 upstream tarball : e81787f1fad34093d8e19f26ae8a5cfcf658ff577ba010a40a586fa4237f9ed2 + make test gaveAll tests successful. Files=4, Tests=8, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.22 cusr 0.04 csys = 0.29 CPU) + Package perl-Test-TrailingSpace-0.0203-1.fc20 Provides: perl(Test::TrailingSpace) = 0.0203 perl-Test-TrailingSpace = 0.0203-1.fc20 Requires: perl(File::Find::Object::Rule) >= 0.0301 perl(Test::More) perl(autodie) perl(strict) perl(warnings) Suggestions: 1) remove following requires. let rpm find and install them for this package. Requires: perl(autodie) Requires: perl(File::Find::Object::Rule) Requires: perl(Test::More) APPROVED. New Package SCM Request ======================= Package Name: perl-Test-TrailingSpace Short Description: Test for trailing space in source files Owners: cicku Branches: f18 f19 InitialCC: Git done (by process-git-requests). perl-Test-TrailingSpace-0.0203-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Test-TrailingSpace-0.0203-1.fc18 perl-Test-TrailingSpace-0.0203-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Test-TrailingSpace-0.0203-1.fc19 perl-Test-TrailingSpace-0.0203-1.fc18 has been pushed to the Fedora 18 testing repository. perl-Test-TrailingSpace-0.0203-1.fc18 has been pushed to the Fedora 18 stable repository. perl-Test-TrailingSpace-0.0203-1.fc19 has been pushed to the Fedora 19 stable repository. |