Bug 980337

Summary: disk-format does not give an error when /dev/sda2 is inexistent
Product: Red Hat Enterprise Linux 6 Reporter: bfan
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED NOTABUG QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.5CC: leiwang, qguan, wshi
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 980338 981663 (view as bug list) Environment:
Last Closed: 2013-07-05 12:35:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description bfan 2013-07-02 06:17:39 UTC 
Description of problem:
disk-format does not give an error when the file is inexistent


Version-Release number of selected component (if applicable):
libguestfs-1.20.9-6.el6.x86_64


How reproducible:
100%


Steps to Reproduce:
[root@]# guestfish -N fs mount /dev/sda1 / : list-partitions : disk-format /dev/sda2 : disk-format /dev/sda3
/dev/sda1
raw
libguestfs: error: realpath: No such file or directory



Actual results:
disk-format /dev/sda2 , returns "raw"


Expected results:
"disk-format /dev/sda2" should give a error message as "disk-format /dev/sda3"


Additional info:
also effect "disk-virtual-size"
Comment 1 Richard W.M. Jones 2013-07-05 12:35:24 UTC 
What's happening is you're using disk-format wrong.  It takes
a host filename, not a libguestfs device or path.

$ guestfish disk-format /etc/passwd
raw

$ ll /dev/sda
brw-rw----. 1 root disk 8, 0 Jun 19 17:49 /dev/sda
$ guestfish disk-format /dev/sda
raw
^ note this only works because I am in the 'disk' group

 - * - * - * -

However, there is an upstream bug too:

$ guestfish disk-format /etc/nosuchfile
libguestfs: error: qemu-img info: JSON parse error: parse error: premature EOF
                                       
                     (right here) ------^

libguestfs: error: qemu-img info: /etc/nosuchfile: qemu-img info exited with error status 1.
To see full error messages you may need to enable debugging.
See http://libguestfs.org/guestfs-faq.1.html#debugging-libguestfs

although this doesn't affect RHEL 6.