Bug 980338

Summary: disk-format "qemu-img info: JSON parse error" when target file does not exist
Product: Red Hat Enterprise Linux 7 Reporter: bfan
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.0CC: leiwang, wshi
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libguestfs-1.22.4-2.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 980337 Environment:
Last Closed: 2014-06-13 12:15:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 981663    
Bug Blocks:    

Description bfan 2013-07-02 06:19:32 UTC 
+++ This bug was initially created as a clone of Bug #980337 +++

Description of problem:
disk-format does not give an error when the file is inexistent


Version-Release number of selected component (if applicable):
libguestfs-1.20.9-6.el6.x86_64


How reproducible:
100%


Steps to Reproduce:
[root@]# guestfish -N fs mount /dev/sda1 / : list-partitions : disk-format /dev/sda2 : disk-format /dev/sda3
/dev/sda1
raw
libguestfs: error: realpath: No such file or directory



Actual results:
disk-format /dev/sda2 , returns "raw"


Expected results:
"disk-format /dev/sda2" should give a error message as "disk-format /dev/sda3"


Additional info:
also effect "disk-virtual-size"
Comment 1 Richard W.M. Jones 2013-07-05 12:38:56 UTC 
Let's reuse this bug to fix the somewhat related problem:

$ guestfish disk-format /etc/nosuchfile
libguestfs: error: qemu-img info: JSON parse error: parse error: premature EOF
                                       
                     (right here) ------^

libguestfs: error: qemu-img info: /etc/nosuchfile: qemu-img info exited with error status 1.
To see full error messages you may need to enable debugging.
See http://libguestfs.org/guestfs-faq.1.html#debugging-libguestfs
Comment 2 Richard W.M. Jones 2013-07-18 13:28:40 UTC 
Fixed upstream in:

https://github.com/libguestfs/libguestfs/commit/aecb5f4b33107935191099dbd5559113f59ee51c
https://github.com/libguestfs/libguestfs/commit/d50cb7bbb4cc18f69ea1425e9f5cee9685825f95
https://github.com/libguestfs/libguestfs/commit/28e08776824dd3152638e647259c2f4701a0a577

and the last one is a regression test:

https://github.com/libguestfs/libguestfs/commit/2311fb0632a64cfa2bab8bf65c82ffaa042d619e
Comment 4 bfan 2013-12-02 05:33:39 UTC 
Verified with libguestfs-1.22.6-16.el7.x86_64

# guestfish disk-format /etc/nosuchfile
libguestfs: error: disk info: /etc/nosuchfile: No such file or directory

It gives a correct error message, change the status to verified
Comment 5 Ludek Smid 2014-06-13 12:15:21 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.