Bug 981381

Summary: In the project errai-cdi-demo-mvp is impossible to create two (or more) new contacts
Product: [Retired] JBoss Enterprise WFK Platform 2 Reporter: Matous Jobanek <mjobanek>
Component: ErraiAssignee: Pavel SLegr <pslegr>
Status: CLOSED INSUFFICIENT_DATA QA Contact: Stefan Miklosovic <smikloso>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 2.3.0CC: csadilek, edewit, jfuerth, kpiwko, oskutka, pslegr, rruss
Target Milestone: CR2   
Target Release: 2.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Known Issue
Doc Text:
Cause: The action "add new contact" uses the same method as the action "edit contact" (in the class "EditContactPresenter" method "doSave") Consequence: In the project errai-cdi-demo-mvp is impossible to create two (or more) new contacts Workaround (if any): Result:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-16 18:23:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Matous Jobanek 2013-07-04 15:08:33 UTC
Description of problem:
In the project errai-cdi-demo-mvp is impossible to create two (or more) new contacts - the cause is that the action "add new contact" uses the same method as the action "edit contact" (in the class "EditContactPresenter" method "doSave")

Version-Release number of selected component (if applicable):
2.3.0


How reproducible:
add two new contacts

Steps to Reproduce:
1. Build project errai-cdi-demo-mvp
2. Deploy it
3. Add new arbitrary contact
4. Add new arbitrary contact (different from first one)

Actual results:
There is only one new contact (the second one) in the list

Expected results:
Two new contacts

Additional info:

Comment 1 Christian Sadilek 2013-07-04 15:45:38 UTC
This has been fixed before:
https://github.com/errai/errai/commit/da2b451dbb62c0956df32f823e06a4018f9436ee

Unfortunately, the fix was lost when the upgraded demos were merged into master. I have cherry-picked the commit onto the 2.3 branch now.

Comment 2 Jonathan Fuerth 2013-07-16 18:23:08 UTC
Migrated to JIRA

Comment 3 JBoss JIRA Server 2013-07-23 08:59:57 UTC
Marek Novotny <mnovotny> made a comment on jira WFK2-34

Clearing proposed Target Release value from 2.0.0.GA to Unknown

Comment 4 JBoss JIRA Server 2013-07-30 18:02:34 UTC
Rodney Russ <rruss> made a comment on jira WFK2-34

Should this issue just move to Errai [~csa] [~jfuerth] ?

Comment 5 JBoss JIRA Server 2013-07-30 18:07:09 UTC
Christian Sadilek <csadilek> made a comment on jira WFK2-34

This issue has been resolved in Errai a while ago (see corresponding bug 981381). There's no need to keep it. I suggest closing it if applying the fix to WFK is not desired.

Comment 6 JBoss JIRA Server 2013-07-31 00:12:57 UTC
Rodney Russ <rruss> updated the status of jira WFK2-34 to Closed

Comment 7 JBoss JIRA Server 2013-07-31 00:12:57 UTC
Rodney Russ <rruss> made a comment on jira WFK2-34

Fixed upstream

Comment 8 JBoss JIRA Server 2013-07-31 07:51:17 UTC
Marek Novotny <mnovotny> made a comment on jira WFK2-34

We need a link to fix, and verification that it is in our product branch. We can't close it!

Comment 9 JBoss JIRA Server 2013-07-31 07:52:30 UTC
Marek Novotny <mnovotny> updated the status of jira WFK2-34 to Reopened

Comment 10 JBoss JIRA Server 2013-07-31 07:52:30 UTC
Marek Novotny <mnovotny> made a comment on jira WFK2-34

[~pslegr] Please verify that we really have the fix in product branch.

Comment 11 JBoss JIRA Server 2013-07-31 08:08:03 UTC
Pavel Slegr <pslegr> made a comment on jira WFK2-34

There is link to fix provided from [~csa] https://github.com/errai/errai/commit/da2b451dbb62c0956df32f823e06a4018f9436ee with explanation, that this fix was lost. It never made it into 2.3.x upstream code and thus is not included in out product branch - so I can verify it's not there. Since we depracate Errai and not include new fixes on Errai itself, I would close it.

Comment 12 JBoss JIRA Server 2013-07-31 08:12:54 UTC
Pavel Slegr <pslegr> made a comment on jira WFK2-34

We are not going to fix it, but this issue needs to remain open and put it into RN as known issue for 2.4 WFK