Bug 981707

I firstly built on my machine and failed, I think something might be wrong within mock, but then I think there are something wrong in your configure script. I've installed libnl1 and 3 with every subpackages on my local machine, and it still failed.

Here is the build task:

http://koji.fedoraproject.org/koji/taskinfo?taskID=5576759

Please fix by reviewing the build.log.

And please remove "rm -rf %{buildroot}" in %install section.

I'll review when you submit the next one.

Fixed:
 * BuildRequires typo s/libnl-devel/libnl3-devel/
 * Removed %{buildroot} deletion in install

INFO: Done(bmon-3.1-1.fc19.src.rpm) Config(fedora-19-x86_64) 1 minutes 40 seconds
INFO: Results and/or logs in: /var/lib/mock/fedora-19-x86_64/result

Ah...Where are the new SRPM?

If you update the package, please bump the release from 1 ---> 2 with%{?dist}

Review from the first URL of SRPM, not sure if this one.

Many issues:

1. 2 files with unknown license

include/bmon/defs.h
include/bmon/list.h

2. In %files section, %{_sysconfdir}/bmon.conf should be:

%config(noreplace) %{_sysconfdir}/bmon.conf

3. rpmlint: 
explicit-lib-dependency libconfuse
explicit-lib-dependency libnl3

4. Manpage has incorrect syntax:
manual-page-warning /usr/share/man/man8/bmon.8.gz 203: warning: macro `NF' not defined
manual-page-warning /usr/share/man/man8/bmon.8.gz 205: warning: macro `FI' not defined

(In reply to Christopher Meng from comment #4)
> Review from the first URL of SRPM, not sure if this one.

spec and SRPM updated in place.

> Many issues:
> 
> 1. 2 files with unknown license
> 
> include/bmon/defs.h

This is auto generated

> include/bmon/list.h

The header clearly states it comes from the kernel source.

> 2. In %files section, %{_sysconfdir}/bmon.conf should be:
> 
> %config(noreplace) %{_sysconfdir}/bmon.conf

Fixed

> 3. rpmlint: 
> explicit-lib-dependency libconfuse
> explicit-lib-dependency libnl3

Removed Requires

> 4. Manpage has incorrect syntax:
> manual-page-warning /usr/share/man/man8/bmon.8.gz 203: warning: macro `NF'
> not defined
> manual-page-warning /usr/share/man/man8/bmon.8.gz 205: warning: macro `FI'
> not defined

Fixed in git tree, will be included in 3.2

explicit-lib-dependency libconfuse
explicit-lib-dependency libnl3

is still appeared, however I think they are false positives.


APPROVED.

New Package SCM Request
=======================
Package Name: bmon
Short Description: bandwidth monitor and rate estimator
Owners: tgraf
Branches: f18 f19 el6
InitialCC:

Git done (by process-git-requests).

> 
> > include/bmon/list.h
> 
> The header clearly states it comes from the kernel source.

Then license tag must be modified, kernel is not BSD.

> Source0: http://www.infradead.org/~tgr/bmon/files/bmon-3.1.tar.gz

Use version macro here, it will really help when doing updates:

Source0: http://www.infradead.org/~tgr/bmon/files/bmon-${version}.tar.gz

More issues:

As you can see in http://kojipkgs.fedoraproject.org//packages/bmon/3.1/1.fc20/data/logs/i686/build.log, make is not verbose, so compiler flags cannot be verified. Add "V=1" to the make call.

AFAICS bmon.conf is not generated during build but comes directly from the source tarball. You should preserve it's timestamp by adding 'INSTALL=install -p' to the 'make install' call.

Fixed in bmon-3.1-4

bmon-3.1-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/bmon-3.1-4.fc20

Thomas,

can you please push bmon to stable?

Or any reason to keep it in testing for many weeks?

(In reply to Terje Røsten from comment #13)
> Thomas,
> 
> can you please push bmon to stable?
> 
> Or any reason to keep it in testing for many weeks?

Pushed to stable.

bmon-3.1-4.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: bmon
New Branches: epel7
Owners: tgraf

Git done (by process-git-requests).