Bug 981971
Summary: | Review Request: python-landslide - Lightweight markup language-based html5 slideshow generator | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Eduardo Echeverria <echevemaster> |
Component: | Package Review | Assignee: | Christopher Meng <i> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | i, notting, package-review |
Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | python-landslide-1.1.1-2.fc19 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-08-11 18:28:06 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Eduardo Echeverria
2013-07-07 11:53:51 UTC
No big problem. 1. main.py under %{python_sitelib}/landslide has env. rpmlint showed: Requires -------- python-landslide (rpmlib, GLIBC filtered): /usr/bin/env (snip) Ah, maybe should be patched, right? 2. MANIFEST.in should be removed from %doc. 3. Do you think it's a good idea or not that creating a subpackage "doc" to store the htmls? 4. rpmlint warned me about the license, seems that %{python_sitelib}/landslide/watcher.py has no license header. Thank you @cicku (In reply to Christopher Meng from comment #1) > No big problem. > > 1. main.py under %{python_sitelib}/landslide has env. rpmlint showed: > > Requires > -------- > python-landslide (rpmlib, GLIBC filtered): > /usr/bin/env > (snip) > > Ah, maybe should be patched, right? Not necessarily, although that is a good practice is a "SHOULD", anyway, is fixed in 2 > > 2. MANIFEST.in should be removed from %doc. Yes, you're right Fixed in 2 > 3. Do you think it's a good idea or not that creating a subpackage "doc" to > store the htmls? the complete documentation is approximately of 260 KB,thinking about the meaning of "large documentation", in this case don't applicable, see https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#PackageDocumentation > 4. rpmlint warned me about the license, seems that > %{python_sitelib}/landslide/watcher.py has no license header. Yes, watcher.py hasn't license header, but i don't see any rpmlint warning about that. rpmlint -v python-landslide-1.1.1-1.fc19.src.rpm python-landslide.src: I: checking python-landslide.src: W: spelling-error Summary(en_US) slideshow -> sideshow, slide show, slide-show python-landslide.src: W: spelling-error %description -l en_US slideshows -> sideshows, slide shows, slide-shows python-landslide.src: I: checking-url https://pypi.python.org/pypi/landslide (timeout 10 seconds) python-landslide.src: I: checking-url https://github.com/adamzap/landslide/archive/a0078400c8e8f2fe19a754c0dbd55e7a3dbb796d/landslide-1.1.1-a007840.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint -v python-landslide-1.1.1-1.fc19.noarch.rpm python-landslide.noarch: I: checking python-landslide.noarch: W: spelling-error Summary(en_US) slideshow -> sideshow, slide show, slide-show python-landslide.noarch: W: spelling-error %description -l en_US slideshows -> sideshows, slide shows, slide-shows anyway the package contains the boilerplate of the Apache License python-landslide.noarch: I: checking-url https://pypi.python.org/pypi/landslide (timeout 10 seconds) python-landslide.noarch: W: no-manual-page-for-binary landslide 1 packages and 0 specfiles checked; 0 errors, 3 warnings. anyway the package contains the boilerplate of the apache license SPEC: http://echevemaster.fedorapeople.org/python-landslide/2/python-landslide.spec SRPM: http://echevemaster.fedorapeople.org/python-landslide/2/python-landslide-1.1.1-2.fc19.src.rpm OK. APPROVED. New Package SCM Request ======================= Package Name: python-landslide Short Description: Lightweight markup language-based html5 slideshow generator Owners: echevemaster Branches: f18 f19 InitialCC: Git done (by process-git-requests). python-landslide-1.1.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-landslide-1.1.1-2.fc19 python-landslide-1.1.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-landslide-1.1.1-2.fc18 python-landslide-1.1.1-2.fc18 has been pushed to the Fedora 18 testing repository. python-landslide-1.1.1-2.fc18 has been pushed to the Fedora 18 stable repository. python-landslide-1.1.1-2.fc19 has been pushed to the Fedora 19 stable repository. |