Bug 982216

Summary: "Pack [Name: Quickstarts and Index: 11] must be installed because it is required!" message during auto.xml installation
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Petr Kremensky <pkremens>
Component: InstallerAssignee: Francisco Canas <fcanas>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.1.1CC: fcanas, myarboro, thauser, tkirby
Target Milestone: ---   
Target Release: EAP 6.1.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-16 20:24:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Kremensky 2013-07-08 12:11:04 UTC
Description of problem:
There is message:
Pack [Name: Quickstarts and Index: 11] must be installed because it is required!
during installation via auto.xml when no quickstarts are installed. 
Installation of quickstarts is not required.

Version-Release number of selected component (if applicable):
EAP 6.1.1 ER2

Steps to Reproduce:
1. install EAP, choose not to install quickstarts, generate auto.xml at the end of installation
2. uninstall EAP
3. install it again using auto.xml generated before

Actual results:
 - "Pack [Name: Quickstarts and Index: 11] must be installed because it is required!" message is shown during installation
 - no quickstarts are installed (that is good :)).

Expected results:
 - "Pack [Name: Quickstarts and Index: 11] removed from selection." message is shown as it is with other excluded components.

Comment 1 Francisco Canas 2013-07-09 17:39:38 UTC
I have fixed the above issue by implementing two changes:

1. The quickstart package is no longer marked 'required' in core-packs.xml.

2. Added a "selectable" attribute to core-packs pack elements. If this attribute is present and set to "false", it prevents the user from manually adding/removing the pack to the installation files in the TreePack panel. This new attribute should be used when the pack can should only be added/removed via conditions in other panels, but not in the TreePackPanel as is the case with Quickstarts.

See these commits for details:

http://git.app.eng.bos.redhat.com/?p=jbossas-installer.git;a=commit;h=cecf3d2291ff6699fb5317713cfa05f35ed85c63

http://git.app.eng.bos.redhat.com/?p=izpack.git;a=commit;h=548a1626d6f2e886b8218115e66f7a3c7f98acab

Comment 2 Petr Kremensky 2013-07-19 07:47:24 UTC
Verified on EAP 6.1.1 ER3. Installer is now acting as Francisco described.