Bug 982630
| Summary: | Documentation : virsh attach-disk --help shouldbe updated with proper examples for --type and --driver | ||
|---|---|---|---|
| Product: | [Community] Virtualization Tools | Reporter: | chandrashekar shastri <cshastri> |
| Component: | libvirt | Assignee: | Libvirt Maintainers <libvirt-maint> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | unspecified | CC: | crobinso, rbalakri |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-04-11 11:34:33 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
I sent a patch upstream: http://www.redhat.com/archives/libvir-list/2016-April/msg00454.html Upstream patch was NACKd in favor of the man page |
By default if we attach the qcow2 image to the guest it adds a raw image. So, one would think --type is meant for qcow2, raw.. etc. which is actually for cdrom, floppy drive.. etc. It would be better if the help page is updated with examples like --type " target device type eg: cdrom, floppy" instead of just "target device type" and supported drivers for --driver qcow2 etc virsh attach-disk --help NAME attach-disk - attach disk device SYNOPSIS attach-disk <domain> <source> <target> [--driver <string>] [--subdriver <string>] [--cache <string>] [--type <string>] [--mode <string>] [--config] [--sourcetype <string>] [--serial <string>] [--shareable] [--rawio] [--address <string>] [--multifunction] [--print-xml] DESCRIPTION Attach new disk device. OPTIONS [--domain] <string> domain name, id or uuid [--source] <string> source of disk device [--target] <string> target of disk device --driver <string> driver of disk device --subdriver <string> subdriver of disk device --cache <string> cache mode of disk device --type <string> target device type --mode <string> mode of device reading and writing --config affect next boot --sourcetype <string> type of source (block|file) --serial <string> serial of disk device --shareable shareable between domains --rawio needs rawio capability --address <string> address of disk device --multifunction use multifunction pci under specified address --print-xml print XML document rather than attach the disk