Bug 982711
Summary: | mgetty locking fails with lockdev patch | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Sarantis Paskalis <paskalis> |
Component: | mgetty | Assignee: | Michal Sekletar <msekleta> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 19 | CC: | msekleta |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | mgetty-1.1.36-22.fc19 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-07-23 01:08:20 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Sarantis Paskalis
2013-07-09 16:11:39 UTC
(Sorry for the empty comment) Description of problem: mgetty fails after upgrading to F19 from F18 Version-Release number of selected component (if applicable): mgetty-1.1.36-21.fc19 How reproducible: Always Relevant log lines: 07/09 08:58:00 opening voice modem device 07/09 08:58:00 voice open 'ttyACM0' 07/09 08:58:00 makelock(ttyACM0) called 07/09 08:58:00 lock not made: dev_lock() failed: Success 07/09 08:58:05 opening voice modem device 07/09 08:58:05 voice open 'ttyACM0' 07/09 08:58:05 makelock(ttyACM0) called 07/09 08:58:05 lock not made: dev_lock() failed: Success 07/09 08:58:10 opening voice modem device 07/09 08:58:10 voice open 'ttyACM0' 07/09 08:58:10 makelock(ttyACM0) called 07/09 08:58:10 lock not made: dev_lock() failed: Success Log with mgetty rebuilt without the lockdev patch: 07/09 19:03:10 opening voice modem device 07/09 19:03:10 voice open 'ttyACM0' 07/09 19:03:10 makelock(ttyACM0) called 07/09 19:03:10 do_makelock: lock='/var/lock/LCK..ttyACM0' 07/09 19:03:10 lock made 07/09 19:03:10 opened voice modem device /dev/ttyACM0 Other notes: "lockdev -l ttyACM0" and "lockdev -u ttyACM0" work from the commandline. I have not built the source with the patch, but glancing it, it seems that it does not initialize the device_name parameter (see the log line "lock not made: dev_lock() failed: Success") Thank you for the report. While implementing this functionality I had issues with not initialized devname parameter, however I put code into the main function which always initializes devname passed later on to lockdev API. I will double check the patch, anyway thanks for the report. Will get back to you shortly. I tried to reproduce the issue but mgetty locked device just fine. I started mgetty on ttyS0, connected to it and tried to run minicom on ttyS0 as well. Minicom refused to run and printed 'Device /dev/ttyS0 is locked.' That being said, I think I know what is the issue here. I modified the patch in way which should work now for all tools (not only mgetty) which are using affected module (locks.c). I built new version for rawhide in koji. See [1] and find attached builds. Could you please verify that it works for you? Thanks. [1] http://koji.fedoraproject.org/koji/buildinfo?buildID=432842 I confirm that the build in comment #3 fixed the locking issue I reported. Please release an update for Fedora 19 as well. Thanks mgetty-1.1.36-22.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mgetty-1.1.36-22.fc19 Would be great if you could test F19 update and leave karma. Thanks. Package mgetty-1.1.36-22.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing mgetty-1.1.36-22.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-12883/mgetty-1.1.36-22.fc19 then log in and leave karma (feedback). mgetty-1.1.36-22.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |