Bug 982733
| Summary: | host-deploy: suppress tar timestamp warning | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Lee Yarwood <lyarwood> | ||||
| Component: | ovirt-engine | Assignee: | Alon Bar-Lev <alonbl> | ||||
| Status: | CLOSED UPSTREAM | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 3.2.0 | CC: | acathrow, alonbl, iheim, jkt, lpeer, pzhukov, Rhev-m-bugs, yeylon | ||||
| Target Milestone: | --- | Keywords: | Triaged | ||||
| Target Release: | 3.3.0 | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | infra | ||||||
| Fixed In Version: | is6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-07-18 13:02:00 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Lee Yarwood
2013-07-09 17:13:20 UTC
It is by design. stderr should be empty in any of the commands we use via the dialog. You can argue that we need to ignore tar errors, but I am unsure this is right. Found that gnu tar can be instructed to suppress these timestamp warnings.
There can be easy workaround in your environment by inserting the following into vdc_options at BootstrapCommand.
Value
---
umask 0077; MYTMP="$(mktemp -t ovirt-XXXXXXXXXX)"; trap "chmod -R u+rwX \"${MYTMP}\" > /dev/null 2>&1; rm -fr \"${MYTMP}\" > /dev/null 2>&1" 0; rm -fr "${MYTMP}" && mkdir "${MYTMP}" && tar --warning=no-timestamp -C "${MYTMP}" -x && "${MYTMP}"/setup DIALOG/dialect=str:machine DIALOG/customization=bool:True
---
But please remember to remove this when upgrading product.
Or just for now have clocks omre or less synced.
Thanks!
(In reply to Alon Bar-Lev from comment #1) > It is by design. > > stderr should be empty in any of the commands we use via the dialog. That might be fine for now but if the dialog is used elsewhere throwing an exception based on stderr output like this might be an issue. Why can't we check the return code? SSH should pass this back from the host to the client after all. > You can argue that we need to ignore tar errors, but I am unsure this is > right. Well these are warnings but I take your point. We should still log these somewhere. (In reply to Alon Bar-Lev from comment #2) > Found that gnu tar can be instructed to suppress these timestamp warnings. > > There can be easy workaround in your environment by inserting the following > into vdc_options at BootstrapCommand. > > Value > --- > umask 0077; MYTMP="$(mktemp -t ovirt-XXXXXXXXXX)"; trap "chmod -R u+rwX > \"${MYTMP}\" > /dev/null 2>&1; rm -fr \"${MYTMP}\" > /dev/null 2>&1" 0; rm > -fr "${MYTMP}" && mkdir "${MYTMP}" && tar --warning=no-timestamp -C > "${MYTMP}" -x && "${MYTMP}"/setup DIALOG/dialect=str:machine > DIALOG/customization=bool:True > --- > > But please remember to remove this when upgrading product. > > Or just for now have clocks omre or less synced. > > Thanks! Yup I'll document this workaround for now. Lee (In reply to Lee Yarwood from comment #3) > (In reply to Alon Bar-Lev from comment #1) > > It is by design. > > > > stderr should be empty in any of the commands we use via the dialog. > > That might be fine for now but if the dialog is used elsewhere throwing an > exception based on stderr output like this might be an issue. > > Why can't we check the return code? SSH should pass this back from the host > to the client after all. Because the complex command sequence may result in errors that we do not expect and not get these via the return code. So I prefer to be safe and make sure stderr does not tell us that there was unexpected error. |