Bug 982748

Summary:	Review Request: perl-Test-Warnings - Test for warnings and the lack of them
Product:	[Fedora] Fedora	Reporter:	Paul Howarth <paul>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Test-Warnings-0.007-1.fc19	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-07-20 09:48:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Paul Howarth 2013-07-09 19:10:26 UTC

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Test-Warnings/branches/fedora/perl-Test-Warnings.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Test-Warnings/perl-Test-Warnings-0.006-2.fc20.src.rpm

Description:

If you've ever tried to use Test::NoWarnings to confirm there are no warnings
generated by your tests, combined with the convenience of done_testing to not
have to declare a test count, you'll have discovered that these two features do
not play well together, as the test count will be calculated before the
warnings test is run, resulting in a TAP error (see examples/test_nowarnings.pl
in this distribution for a demonstration).

This module is intended to be used as a drop-in replacement for
Test::NoWarnings: it also adds an extra test, but runs this test before
done_testing calculates the test count, rather than after. It does this by
hooking into done_testing as well as via an END block. You can declare a plan,
or not, and things will still Just Work.

It is actually equivalent to:

    use Test::NoWarnings 1.04 ':early';

as warnings are still printed normally as they occur. You are safe, and
enthusiastically encouraged, to perform a global search-replace of the above
with use Test::Warnings; whether or not your tests have a plan.

Fedora Account System Username: pghmcfc

Comment 1 Paul Howarth 2013-07-10 18:47:52 UTC

New upstream release:

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Test-Warnings/branches/fedora/perl-Test-Warnings.spec

SRPM URL: http://www.city-fan.org/~paul/extras/perl-Test-Warnings/perl-Test-Warnings-0.007-1.fc20.src.rpm

Comment 2 Parag AN(पराग) 2013-07-11 04:58:45 UTC

Review:

+ mock build is successful for f20

+ rpmlint output on rpms gave
perl-Test-Warnings.noarch: W: spelling-error %description -l en_US NoWarnings -> No Warnings, No-warnings, Warning
perl-Test-Warnings.noarch: W: spelling-error %description -l en_US nowarnings -> no warnings, no-warnings, warning
perl-Test-Warnings.src: W: spelling-error %description -l en_US NoWarnings -> No Warnings, No-warnings, Warning
perl-Test-Warnings.src: W: spelling-error %description -l en_US nowarnings -> no warnings, no-warnings, warning
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
==> ignore these

+ Source verified with upstream as (sha256sum)
srpm tarball     : faca86d64ef355dec77101c8e037bd9791e122cfee3660d0dce67c384b18ce05
upstream tarball : faca86d64ef355dec77101c8e037bd9791e122cfee3660d0dce67c384b18ce05

+ License "GPL+ or Artistic" is valid and included in source files.

+ rest follows packaging guidelines

+ make test is successful with output
All tests successful.
Files=12, Tests=57,  1 wallclock secs ( 0.05 usr  0.02 sys +  0.36 cusr  0.04 csys =  0.47 CPU)

+ Package  perl-Test-Warnings-0.007-1.fc20.noarch
Provides: perl(Test::Warnings) = 0.007 perl-Test-Warnings = 0.007-1.fc20
Requires: perl(Exporter) perl(Test::Builder) perl(parent) perl(strict) perl(warnings)

APPROVED.

Comment 3 Paul Howarth 2013-07-11 06:56:19 UTC

New Package SCM Request
=======================
Package Name: perl-Test-Warnings
Short Description: Test for warnings and the lack of them
Owners: pghmcfc
Branches: f18 f19
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2013-07-11 10:53:35 UTC

Git done (by process-git-requests).

Comment 5 Fedora Update System 2013-07-11 14:41:21 UTC

perl-Test-Warnings-0.007-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Test-Warnings-0.007-1.fc19

Comment 6 Fedora Update System 2013-07-11 14:41:32 UTC

perl-Test-Warnings-0.007-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/perl-Test-Warnings-0.007-1.fc18

Comment 7 Fedora Update System 2013-07-12 03:05:27 UTC

perl-Test-Warnings-0.007-1.fc18 has been pushed to the Fedora 18 testing repository.

Comment 8 Fedora Update System 2013-07-20 09:48:09 UTC

perl-Test-Warnings-0.007-1.fc18 has been pushed to the Fedora 18 stable repository.

Comment 9 Fedora Update System 2013-07-20 09:50:11 UTC

perl-Test-Warnings-0.007-1.fc19 has been pushed to the Fedora 19 stable repository.