Bug 983340
| Summary: | Review Request: fcitx-kkc - Japanese Kana Kanji Engine for Fcitx | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daiki Ueno <dueno> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | dueno, i18n-bugs, i, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | fcitx-kkc-0.1.0-3.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-11-10 08:11:41 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Daiki Ueno
2013-07-11 03:08:36 UTC
Review: + mock build is successful for f20 - rpmlint output on rpms gave fcitx-kkc.src: W: spelling-error %description -l en_US libkkc -> lick fcitx-kkc.x86_64: W: spelling-error %description -l en_US libkkc -> lick fcitx-kkc.x86_64: W: no-documentation fcitx-kkc.x86_64: W: devel-file-in-non-devel-package /usr/include/fcitx/module/kkc/fcitx-kkc.h 3 packages and 0 specfiles checked; 0 errors, 4 warnings. ==> you may want to remove header file + Source verified with upstream as (sha256sum) srpm tarball : c364c991b09c88f0dc7475497ab37df7919a495f77b48bc88a094e9a43630c9b upstream tarball : c364c991b09c88f0dc7475497ab37df7919a495f77b48bc88a094e9a43630c9b - License should be GPLv3+ - Directory ownership issues /usr/share/fcitx/imicon /usr/share/fcitx/inputmethod I can't find who owns these. suggestions: 1) we don't need now rm -rf $RPM_BUILD_ROOT ping ping? ping ah! not sure why bugzilla removed CC of package-review.org. Let's add it back. Sorry for the long delay. Updated the package: Spec URL: http://ueno.fedorapeople.org/fcitx-kkc/fcitx-kkc.spec SRPM URL: http://ueno.fedorapeople.org/fcitx-kkc/fcitx-kkc-0.1.0-2.fc19.src.rpm (In reply to Parag AN(पराग) from comment #1) > - License should be GPLv3+ Done. > - Directory ownership issues > /usr/share/fcitx/imicon > /usr/share/fcitx/inputmethod > > I can't find who owns these. Since 4.2.8-3, the fcitx package owns those directories: http://pkgs.fedoraproject.org/cgit/fcitx.git/commit/?id=b6284bbc85b3bc754f09f0c8c01fb91abfd41637 > suggestions: > 1) we don't need now > rm -rf $RPM_BUILD_ROOT Done. Suggestions:
1) Can header file be removed as I see no use of it?
2) I am not sure who owns this
%{_libdir}/fcitx/qt
if no one let this package own this also.
APPROVED.
Thanks for the review, will fix those when importing. New Package SCM Request ======================= Package Name: fcitx-kkc Short Description: Japanese Kana Kanji Engine for Fcitx Owners: ueno Branches: f20 InitialCC: i18n-team Git done (by process-git-requests). fcitx-kkc-0.1.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/fcitx-kkc-0.1.0-3.fc20 fcitx-kkc-0.1.0-3.fc20 has been pushed to the Fedora 20 testing repository. fcitx-kkc-0.1.0-3.fc20 has been pushed to the Fedora 20 stable repository. |