Bug 983552
| Summary: | Rfe: shorten paths | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | Heiko W. Rupp <hrupp> | ||||||||
| Component: | No Component | Assignee: | John Mazzitelli <mazz> | ||||||||
| Status: | ON_QA --- | QA Contact: | |||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 4.8 | CC: | hrupp, mazz | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | Type: | Bug | |||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
> rhq-server-startup-subsystem to server
we should at least make it more descriptive. "server" and "rhq-server.jar" will be confusing (if we tell people "look in 'server'" I'm sure people will then ask "server" or "rhq-server.jar"?).
I think "server" should be renamed to something like "startup" or "rhq-startup". Its the startup subsystem that is responsible for deploying the ear.
Created attachment 772380 [details]
Patch 2 - renamed module to server-startup
Attached is the same patch as before, except it renames the startup module "server-startup" rather than "server" to make it clearer what it is and makes it more descriptive.
Created attachment 772387 [details]
Patch 3 - renamed module to server-startup
turns out, the dev container was not correct in the original patch, or my second one. I needed to fix it. attached is the latest patch that should work. still testing...
git commit to master: 957781e62543ff5023c4b59567ee76c6ab2a9d9a the ejb3 jar is now "rhq-server.jar" and the startup module name is "server-startup" to test, just look in the file system after unzipping the distro and make sure you have: rhq-server/modules/org/rhq/server-startup and you do NOT have: rhq-server/modules/org/rhq/rhq-enterprise-server-startup-subsystem In addition, make sure you have: rhq-server/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-server.jar and you do NOT have rhq-server/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-enterprise-server-ejb3.jar Awesome - even if I am not completely convinced with the "startup" name, as this also contains the ear (and the downloads etc). But a huge improvement to the past. |
Created attachment 772213 [details] Patch If you look at jbossas/modules/org/rhq you'll find some pretty long path names, which are annoying when you want to describe where things are. Also on Win* there is the issue with total path name length. The attached patch will shorten rhq-server-startup-subsystem to server and rhq-enterprise-server-ejb3.jar to rhq-server.jar as a starting point