Bug 983556
| Summary: | "Package consistently uses macro is (..)." | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
| Component: | fedora-review | Assignee: | Stanislav Ochotnicky <sochotni> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 19 | CC: | leamas.alec, pingou, sochotni |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-30 13:28:45 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Hm... this should be fixed in 3daa8d6683, dated Jan 28, 2013. I certainly see it in older branches, but not in current devel. Could you please provide a more specific test case, including a bug and last commit in devel? Sure: $ rpm -q fedora-review fedora-review-0.4.1-2.fc19.noarch $ rpm -ql fedora-review | LANG=C xargs grep -d skip "uses macro is" Binary file /usr/share/fedora-review/plugins/generic.pyc matches Binary file /usr/share/fedora-review/plugins/generic.pyo matches $ rpm -V fedora-review $ Perhaps the python files were not recompiled properly? Same for rawhide You're right it is fixed in upstream devel branch but still present in the master branch. As explained in the wiki, the master branch is not really useful in the model we use - it's basically just the release branches collected over time. The important thing is that this is fixed in devel, the upcoming release. Since we agree on this I close this. Thanks for reporting the issue (and for all checking!) Can we keep this open until it is available in current releases? When do you plan to update the f19 package say? Fixed in 0.5.0 release. |
Description of problem: plugins/generic.py seems to generate the text "Package consistently uses macro is (..)." ^^^^^^^^ in review.txt, which does not make sense! I suppose it should just say "Package consistently uses *macros* (..)." Version-Release number of selected component (if applicable): fedora-review-0.4.1-2.fc19 How reproducible: 100% Additional info: I see the same in the master and devel branches in git.