Bug 983614 (gpaw-setups)

Summary:	Review Request: gpaw-setups - Atomic PAW setups for gpaw
Product:	[Fedora] Fedora	Reporter:	Susi Lehtola <susi.lehtola>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	i, Marcin.Dulak, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-04-22 13:37:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	983608

Description Susi Lehtola 2013-07-11 14:38:36 UTC

Spec URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/gpaw-setups.spec

SRPM URL: 
http://theory.physics.helsinki.fi/~jzlehtol/rpms/gpaw-setups-0.9.9672-1.fc19.src.rpm

Description:
A setup is to the PAW method what a pseudo-potential is to the
pseudo-potential method.  This package contains setups for the LDA,
PBE, revPBE, RPBE and GLLBSC functionals necessary for normal
operation of GPAW.

Fedora Account System Username: jussilehtola

rpmlint output:
gpaw-setups.noarch: W: spelling-error %description -l en_US revPBE -> Revere
gpaw-setups.noarch: W: spelling-error %description -l en_US functionals -> functional, functional s, functionary
gpaw-setups.noarch: W: no-documentation
gpaw-setups.noarch: W: non-conffile-in-etc /etc/profile.d/gpaw-setups.sh
gpaw-setups.noarch: W: non-conffile-in-etc /etc/profile.d/gpaw-setups.csh
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

These are all non-issues.

Comment 1 Christopher Meng 2013-07-11 15:28:41 UTC

Hi,

Please remove BuildRoot tag, rm -rf %{buildroot} in
%install section, whole %clean section and %defattr(-,root,root,-) from your
spec.

Comment 2 Susi Lehtola 2013-07-11 16:51:42 UTC

(In reply to Christopher Meng from comment #1)
> Please remove BuildRoot tag, rm -rf %{buildroot} in
> %install section, whole %clean section and %defattr(-,root,root,-) from your
> spec.

As in bug #983608, these are first of all not incorrect, and secondly are actually necessary for building the package on EPEL.

Comment 3 marcindulak 2014-04-22 09:44:07 UTC

Please update to the latest gpaw-setups tarball.

Please install the setups under %{_datadir}/%{name} and do not create
%{_sysconfdir}/profile.d/ scripts. GPAW has the default GPAW_SETUP_PATH directory
set in https://trac.fysik.dtu.dk/projects/gpaw/browser/trunk/gpaw/__init__.py
to be /usr/local/share/gpaw-setups:/usr/share/gpaw-setups

/usr/local/share/gpaw-setups is used on OSX.

Comment 4 marcindulak 2014-04-22 13:37:58 UTC


*** This bug has been marked as a duplicate of bug 1090070 ***