Bug 983782

Summary:	Filtering that drops the last page causes unexpected behaviour
Product:	[Retired] Zanata	Reporter:	Damian Jansen <djansen>
Component:	Usability	Assignee:	Alex Eng <aeng>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Damian Jansen <djansen>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	development	CC:	aeng, zanata-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-11-27 03:32:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	978656

Description Damian Jansen 2013-07-12 00:41:36 UTC

Description of problem:
Scenario -
* User has a filter in place
* Filter shows 2 (or more) pages of results
* User is on second last page
* User edits enough items on the current page such that there are no valid rows for the last page

Version-Release number of selected component (if applicable):
Dev

How reproducible:
Moderate, but consistent

Steps to Reproduce:
1. Have a doc with untranslated items
2. Click Incomplete filter - > Untranslated
3. Go to last page, take note of how many (number of items) items are on last page
4. Go to second last page
5. Translate (number of items) and save them as fuzzy
6. Press the next page button
7. No content page appears, with e.g. 3/2 pages and an available Next button
8. Press the Next page button
8. Goes to Page 1

Actual results:
Current page is higher than the total number of pages, next page wraps to page one

Expected results:
If the current page would be higher than total number of pages, then go to last page

Additional info:

Comment 1 Damian Jansen 2013-07-12 00:44:12 UTC

I'm going to add it as a block to 978656, but it's reasonably trivial and may not be directly related to the new filtering.

Comment 2 Alex Eng 2013-07-20 11:28:39 UTC

Implemented.
See:

https://github.com/zanata/zanata-server/commit/3799cdebe9d5cf6286308cc9a12cb68db4b655e2

https://github.com/zanata/zanata-server/commit/b83d22e3673c4bcd5d0343ca6e9a4b2e2efe2c8b

https://github.com/zanata/zanata-server/commit/5dd23a0dda5eb98058b13b7b9c794e8d2c8f1947

https://github.com/zanata/zanata-server/commit/5033267dbb871e2008c01332f7176f3ac086b77f

https://github.com/zanata/zanata-server/commit/bc8876888199f5fbdb4932c175b81cb8fefcbd3e

https://github.com/zanata/zanata-server/commit/5c19bd2a33114228cad3d03ce2d2eaffbac4962e

Comment 3 Damian Jansen 2013-07-21 22:32:17 UTC

Tested at df00dc1cab4e993a5f0d98cf84faacb8f60f6381
Looks good.

Comment 4 Sean Flanigan 2013-11-27 03:32:40 UTC

Closing VERIFIED bugs which predate Zanata 3.1.2.