Bug 983964
| Summary: | e-calendar-factory performs network io for caldav in the main thread | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | David Jaša <djasa> | ||||||
| Component: | evolution-data-server | Assignee: | Milan Crha <mcrha> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 6.5 | CC: | jkoten, mcrha, tpelka | ||||||
| Target Milestone: | beta | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | evolution-data-server-2.32.3-10.el6 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-11-21 04:54:23 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
David Jaša
2013-07-12 11:57:49 UTC
We've gone to great lengths to fix this sort of thing in the years since 2.32 was released. It's not something we can easily fix in such an old version. We're gonna have to just live with it in RHEL 6. Matthew, I may have been too nice at reporting. The 2.28 didn't suffer from this problem and it causes serious usability issues all over the place - such as not responding clock applet being displayed on top of all windows for _minutes_ till the caldav timeout kicks in... I'll attach backtraces for both cases. I will try to cook something semi-hackish, and we'll see. I had a chat with David before he filled this bug report, thus it's fine I'll take care of it. Created attachment 773814 [details] proposed eds patch for evolution-data-server; This adds a thread pool into EDataCal, which calls (almost) each request in a separate thread, basically like the EDataBook does it. It helps in many cases, because the calendars are not opened in a serial way, but in a parallel, though it doesn't help always, like with MAPI, which is completely single-threaded currently, also between different instances. It's because the libraries used by it are not thread safe. Here's [1] a test build of evolution-data-server-2.32.3-8.1.el6 with it included. It contains test patches for this bug, bug #979722 and bug #950005. [1] https://brewweb.devel.redhat.com/taskinfo?taskID=6036568 Quick question before I actually try the build - will it change CardDAV contacts as well? (In reply to David Jaša from comment #7) > Quick question before I actually try the build - will it change CardDAV > contacts as well? No, the change is for calendar part only. Addressbook part has this pool implemented already. Do you see the same lags in addressbook part as well? Maybe it's just the part which cannot be fixed, I'm afraid. I wasn't able to induce longish UI waits when trying to mimick network unavailability with iptables -j DROP, the longest was about 3-4 seconds and I couldn't repeat it. So the bug is indeed fixed. I'm not sure about CardDAV, I reenabled autocompletion on one such calendar so let's see if it will hang the UI when typing addresses... Thanks for the testing. I'll commit this by tomorrow, when you finish testing of the other bugs. Created attachment 778848 [details]
(correct) eds patch
for evolution-data-server;
Oops, I attached a wrong eds patch, this is the correct one.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2013-1540.html |