Bug 983969

Summary: RFE: virt-sysprep should be SELinux-aware
Product: [Community] Virtualization Tools Reporter: Richard W.M. Jones <rjones>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED UPSTREAM QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: mbooth, ptoscano, rbalakri
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-14 14:47:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1089100    
Bug Blocks:    

Description Richard W.M. Jones 2013-07-12 12:21:41 UTC 
Description of problem:

'virt-sysprep --selinux' flag should:

  loadpolicy

(for guests which support this) so that SELinux labelling
works properly.  When this flag is specified, DON'T set
autorelabel.  The autorelabel step takes too long!

(Requested by Mark @ catn.com)
Comment 1 Pino Toscano 2014-06-10 15:47:35 UTC 
Since libguestfs 1.26 virt-sysprep has --selinux-relabel which should do the job (either relabel files if possible, or touch /.autorelabel if not), modulo bugs (#1089100).

Should this be closed at this point, leaving #1089100 (and eventually others) to deal with bugs of --selinux-relabel?
Comment 2 Richard W.M. Jones 2014-06-10 16:57:29 UTC 
Even better, let's make it a dependency ...
Comment 3 Richard W.M. Jones 2016-07-14 14:47:55 UTC 
These patches comprehensively fix the --selinux-relabel option,
so let's close this.

https://github.com/libguestfs/libguestfs/commit/9d205f1c284a69390907120ca44f5c723fecc244
https://github.com/libguestfs/libguestfs/commit/6ec75f8cfe455493b46f1a3a5a00282359e588a5
https://github.com/libguestfs/libguestfs/commit/f3c69fe60bc29ebfcef0ea9d86d407e1a88686b0
https://github.com/libguestfs/libguestfs/commit/b6e92b1100b4ca462a35549bd36322f0510739bc
https://github.com/libguestfs/libguestfs/commit/35bac3a6501354e4a3805877d950e741429f169b
https://github.com/libguestfs/libguestfs/commit/fc114904848559e02d8f4e4a8bfb57277c349f0f