Bug 984173

Summary: Disable versioned OpenBabel data directories
Product: [Fedora] Fedora Reporter: Susi Lehtola <susi.lehtola>
Component: openbabelAssignee: Susi Lehtola <susi.lehtola>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dominik, i, itamar, paul, susi.lehtola
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openbabel-2.3.2-1.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-28 01:07:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Proposed patch none

Description Susi Lehtola 2013-07-13 09:00:22 UTC
OpenBabel provides force field data and libraries, which are needed for operating software that is built against openbabel.

Please provide rpm macros which state the version of the openbabel library, and the exact location of the data and library directories.

Comment 1 Susi Lehtola 2013-07-13 09:04:13 UTC
Created attachment 772974 [details]
Proposed patch

This patch adds the rpm macros, and also cleans up the packaging somewhat by removing duplicate html man pages, and branching out the documentation and the force fields to separate subpackages.

Comment 2 Susi Lehtola 2013-07-13 09:05:38 UTC
The patch also takes care of the trivial part of bug #865621, but I can't get openbabel to compile due to an obsolete Ruby makefile

-- Found Ruby: /usr/bin/ruby (found version "2.0.0") 
-- Ruby bindings will be compiled
-e:1:in `<main>': Use RbConfig instead of obsolete and deprecated Config.
-e:1:in `<main>': Use RbConfig instead of obsolete and deprecated Config.
-- Configuring incomplete, errors occurred!
error: Bad exit status from /var/tmp/rpm-tmp.wWLTSK (%build)

Comment 3 Susi Lehtola 2013-07-15 09:02:35 UTC
Alternatively, since we're only going to have one version of OpenBabel installed anyhow, this problem would be solved by not using version dependent locations for the libraries and the force fields.

Then the soname dependency automatically picked up by rpm would be sufficient.

Comment 4 Susi Lehtola 2013-07-18 00:21:18 UTC
(In reply to Susi Lehtola from comment #2)
> The patch also takes care of the trivial part of bug #865621, but I can't
> get openbabel to compile due to an obsolete Ruby makefile

What am I saying. That's not the error, the error is in the CMake makefile using the same target name twice.

Anyway, I can handle the updates, but I'd like to hear your opinion on the location issue.

Comment 5 Susi Lehtola 2013-07-18 08:53:08 UTC
Actually, since the versioned library locations can be turned off as a configure option I'm going ahead and doing the change in rawhide.

Comment 6 Dominik 'Rathann' Mierzejewski 2013-07-18 09:10:36 UTC
I'm fine with your changes and I've just approved your commit access. Thanks for your help.

Comment 7 Fedora Update System 2013-07-18 11:56:52 UTC
openbabel-2.3.2-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/openbabel-2.3.2-1.fc19

Comment 8 Fedora Update System 2013-07-18 11:57:11 UTC
openbabel-2.3.2-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/openbabel-2.3.2-1.fc18

Comment 9 Fedora Update System 2013-07-20 09:30:43 UTC
Package openbabel-2.3.2-1.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing openbabel-2.3.2-1.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-13229/openbabel-2.3.2-1.fc19
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2013-07-28 01:07:51 UTC
openbabel-2.3.2-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2013-07-28 01:11:05 UTC
openbabel-2.3.2-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.