Bug 984318

Test on devenv-stage_404,I can create the app with custom cartridge (https://raw.github.com/bmeng/downloadable-mock/master/metadata/manifest.yml),and can delete the app successfully.

I have deleted your apps.  It may take some time for your "consumed gears" count to catch up, due to the way force-deletions work.

I will separately try to reproduce this issue with the information you've provided.  Thanks.

Hello,

How did you create this app? I tried:

$ bx bin/rhc app create meteor https://raw.github.com/dpwhittaker/openshift-meteor-cartridge/master/metadata/manifest.yml
The cartridge 'https://raw.github.com/dpwhittaker/openshift-meteor-cartridge/master/metadata/manifest.yml' will be downloaded and installed

Application Options
-------------------
  Namespace:  fooooooooooo
  Cartridges: https://raw.github.com/dpwhittaker/openshift-meteor-cartridge/master/metadata/manifest.yml
  Gear Size:  default
  Scaling:    no

Creating application 'meteor' ... 
Unable to complete the requested operation due to: Node execution failure (invalid exit code from node).  If the problem persists please contact Red Hat support..
Reference ID: a941916bdd90bc546e5b44dad2f3ba8b

(In reply to Hiro Asari from comment #3)
> Hello,
> 
> How did you create this app? I tried:
> 
> $ bx bin/rhc app create meteor
> https://raw.github.com/dpwhittaker/openshift-meteor-cartridge/master/
> metadata/manifest.yml
> The cartridge
> 'https://raw.github.com/dpwhittaker/openshift-meteor-cartridge/master/
> metadata/manifest.yml' will be downloaded and installed
> 
> Application Options
> -------------------
>   Namespace:  fooooooooooo
>   Cartridges:
> https://raw.github.com/dpwhittaker/openshift-meteor-cartridge/master/
> metadata/manifest.yml
>   Gear Size:  default
>   Scaling:    no
> 
> Creating application 'meteor' ... 
> Unable to complete the requested operation due to: Node execution failure
> (invalid exit code from node).  If the problem persists please contact Red
> Hat support..
> Reference ID: a941916bdd90bc546e5b44dad2f3ba8b

That is one of the ways I tried to create the app (the other was through the console).  I got the same error message.  But then the Application was created, but had no cartridges in the console.

After tried to create app with the cartridge, it gets failure, and cannot find the app after that on denenv-stage_406.

[root@ip-10-151-24-170 ~]# rhc app create app1 https://raw.github.com/dpwhittaker/openshift-meteor-cartridge/master/metadata/manifest.yml
The cartridge 'https://raw.github.com/dpwhittaker/openshift-meteor-cartridge/master/metadata/manifest.yml' will be downloaded and installed

Application Options
-------------------
  Namespace:  bmeng
  Cartridges: https://raw.github.com/dpwhittaker/openshift-meteor-cartridge/master/metadata/manifest.yml
  Gear Size:  default
  Scaling:    no

Creating application 'app1' ... 
Unable to complete the requested operation due to: Node execution failure (invalid exit code from node).  If the problem persists please contact Red Hat support..
Reference ID: cefb601d9ab1d067b699d0f4a7893dc0
[root@ip-10-151-24-170 ~]# rhc domain show
The domain bmeng exists but has no applications. You can use 'rhc create-app' to create a new application.

David,

As you can see, there are many things we can improve during the custom cartridge development cycle. It is rather difficult to understand how things went south without the access to the server logs.

I spent a little time examining your cartridge, and found a few mistakes.

1. The process_templates value in managed_files.yml needs to be a string literal.

2. Scripts under 'bin' are executed directly, so they need to have the executable bit on. ('chmod +x' on UNIX; perhaps there is a GUI dialog on Windows)

3. Currently, 'bin/control' appears to have DOS line endings. Since it will be executed on a Linux machine, the line endings should be '\n', not '\r\n'.

4. Environment variables need to be "published". For example, the Node.js cartridge makes them available like this: https://github.com/openshift/origin-server/blob/master/cartridges/openshift-origin-cartridge-nodejs/metadata/manifest.yml.0.6#L19-L49

Additionally, study how bin/setup in the Node.js cartridge creates directories so that logs can be subsequently created.

There may be more issues to consider, but those will probably involve design decisions that only you can answer.

Some of these issues are undoubtedly due to incomplete documentation (https://github.com/openshift/origin-server/blob/master/node/README.writing_cartridges.md). We will work on that.

In the meantime, make the changes shown above, and let us know how it goes.

Thank you.

Also, the bash functions cannot have empty bodies, so status() and friends need to have something (as simple as just "true") in it.

status(), by the way, needs to echo correct message in order to function correctly. See what other cartridges are doing.

I'm sort of weekend warrior on this project.  Thanks for taking the time to look at it, and I'll try these out when I get a few free hours.

David, any update on this?

Seems the initial problem with the application deletion failure was an anomaly, and I have provided some additional pointers for your cartridge.

If there is nothing else to address, may we close this ticket?

Sure, I'll just open a new bug if these suggestions dont help when I get to it.

Thank you for the update, David. I'm closing this now.