Bug 984472
| Summary: | [Permanent fix] Backport of GTNPORTAL-3182, GTNPORTAL-3156 and GTNPORTAL-3246 | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise Portal Platform 6 | Reporter: | Adam Kovari <akovari> |
| Component: | Portal | Assignee: | Peter Palaga <ppalaga> |
| Status: | CLOSED UPSTREAM | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | high | ||
| Version: | 6.0.0 | CC: | epp-bugs, jpallich, nobody, ppalaga, tkyjovsk |
| Target Milestone: | DR01 | ||
| Target Release: | 6.1.1 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | FixAvail | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Maximizing a portlet did not work properly when called from processEvent(). render() was invoked on too many portlets, including those portlets with unchanged states. This action caused inconsistencies in window states of the portlets on the current page. The fix implements changes to ChangeWindowStateActionListener, which now checks the state of all portlets on the current page to prevent two portlets being maximized at the same time.
As a result, maximizing portlets in the process events phase now works correctly.
|
Story Points: | --- |
| Clone Of: | 984405 | Environment: |
- JPP 6.0
|
| Last Closed: | 2025-02-10 03:28:05 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 984405 | ||
| Bug Blocks: | |||
|
Description
Adam Kovari
2013-07-15 10:29:50 UTC
Adam Kovari <akovari> made a comment on jira GTNPORTAL-3182 Reproducer portlet Adam Kovari <akovari> made a comment on jira GTNPORTAL-3182 Configuration for the reproducer Adam Kovari <akovari> made a comment on jira GTNPORTAL-3182 I have added some more code to make sure that maximization of multiple portlets one after another works properly when done using AJAX code. This works fine as it triggers an Action request. Adam Kovari <akovari> updated the status of jira GTNPORTAL-3182 to Reopened Adam Kovari <akovari> made a comment on jira GTNPORTAL-3182 Sending new pull request: https://github.com/gatein/gatein-portal/pull/594 Trong Tran <trongtt> made a comment on jira GTNPORTAL-3182 There is still another small problem with Portlet maximization : 1. Click on the maximize icon of a portlet in Home page 2. Switch to Sitemap page 3. Switch back to Home page. The previously maximized portlet is restore to Normal ==> NOK Adam Kovari <akovari> made a comment on jira GTNPORTAL-3182 Let me take a look at that too. Thanks Adam Kovari <akovari> made a comment on jira GTNPORTAL-3182 I have fixed this in UIPortal.refreshPage() by commenting out code that sets null to maximized component. BTW I noticed UIPortal has again maximized component field, so now there are 3 places - UIPage,UIPageBody and UIPortal, maybe this should be unified. Another problem I discovered was minimizing portlet that got maximized from the producer portlet using event before. This should work now as well. Trong Tran <trongtt> made a comment on jira GTNPORTAL-3182 UIPortal maintains a different maximized component which is used to show full portal space. BUT seems now it doesn't work :( Adam Kovari <akovari> made a comment on jira GTNPORTAL-3182 Could you be more specific? I tried virtually any window state change I could think of and it worked fine. Trong Tran <trongtt> made a comment on jira GTNPORTAL-3182 I mean a portlet in Portal layout can be maximized, just like in Page layout Adam Kovari <akovari> made a comment on jira GTNPORTAL-3182 Hmm, so do you think PR 609 is now safe to merge? I guess UIPortal maximized component is somewhat unrelated to this JIRA anyway. Trong Tran <trongtt> made a comment on jira GTNPORTAL-3182 Yes, I think the PR is ok to merge. I just created another JIRA for maximized component in Portal layout GTNPORTAL-3233 Adam Kovari <akovari> made a comment on jira GTNPORTAL-3156 Updated the PR based on Tran's suggestions. Trong Tran <trongtt> made a comment on jira GTNPORTAL-3156 The Fix Version/s is not set properly, it should be 3.7.0.Final (master) instead Peter Palaga <ppalaga> made a comment on jira GTNPORTAL-3246 One more related PR was merged: https://github.com/gatein/gatein-portal/pull/640 If this issue requires mention in release notes (as indicated by the requires_doc_text flag) draft content must be provided by the engineer responsible. Please complete the Doc Text field and supply draft info. Docs can do any edits required and mark the issue for inclusion in the Release Notes for RHJP 6.1.1 I cannot set requires_doc_text to +. (In reply to Peter Palaga from comment #19) > I cannot set requires_doc_text to +. Hi Peter Thanks for the CCFR text. You don't need to worry about setting the flag to + - this is done by the docs team after we've reviewed it. However if you can't set the flag to minus, that could be a reason why we're seeing all these bugs without any flag status set. Devs may simply not be able to set the flag (could you check if minus is something you can set)? This product has been discontinued or is no longer tracked in Red Hat Bugzilla. |